Revert "Remove unnecessary references, not harmful in the absence of RVO but redundant due to move semantics"
This reverts commit b0d09926a1.
Misguided original change.
This commit is contained in:
parent
b0d09926a1
commit
d9aa04778a
1 changed files with 3 additions and 3 deletions
|
|
@ -179,12 +179,12 @@ MemberList::lessThan(const QModelIndex &source_left, const QModelIndex &source_r
|
||||||
return QSortFilterProxyModel::lessThan(source_left, source_right);
|
return QSortFilterProxyModel::lessThan(source_left, source_right);
|
||||||
}
|
}
|
||||||
|
|
||||||
const QString left =
|
const QString &left =
|
||||||
this->m_model.data(source_left, MemberListBackend::Roles::Mxid).toString();
|
this->m_model.data(source_left, MemberListBackend::Roles::Mxid).toString();
|
||||||
const QString right =
|
const QString &right =
|
||||||
this->m_model.data(source_right, MemberListBackend::Roles::Mxid).toString();
|
this->m_model.data(source_right, MemberListBackend::Roles::Mxid).toString();
|
||||||
|
|
||||||
const std::string room_id = this->roomId().toStdString();
|
const std::string &room_id = this->roomId().toStdString();
|
||||||
if (cache::isV12Creator(room_id, left.toStdString())) {
|
if (cache::isV12Creator(room_id, left.toStdString())) {
|
||||||
if (!cache::isV12Creator(room_id, right.toStdString())) {
|
if (!cache::isV12Creator(room_id, right.toStdString())) {
|
||||||
return false;
|
return false;
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue