From d9aa04778a67f4cf478dfac230642b47417a4113 Mon Sep 17 00:00:00 2001 From: Sofia/Nep Date: Mon, 26 Jan 2026 16:39:20 -0300 Subject: [PATCH] Revert "Remove unnecessary references, not harmful in the absence of RVO but redundant due to move semantics" This reverts commit b0d09926a12757d3b3066a6be62975bbd5a9f5aa. Misguided original change. --- src/MemberList.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/MemberList.cpp b/src/MemberList.cpp index fea027a3..bc493165 100644 --- a/src/MemberList.cpp +++ b/src/MemberList.cpp @@ -179,12 +179,12 @@ MemberList::lessThan(const QModelIndex &source_left, const QModelIndex &source_r return QSortFilterProxyModel::lessThan(source_left, source_right); } - const QString left = + const QString &left = this->m_model.data(source_left, MemberListBackend::Roles::Mxid).toString(); - const QString right = + const QString &right = this->m_model.data(source_right, MemberListBackend::Roles::Mxid).toString(); - const std::string room_id = this->roomId().toStdString(); + const std::string &room_id = this->roomId().toStdString(); if (cache::isV12Creator(room_id, left.toStdString())) { if (!cache::isV12Creator(room_id, right.toStdString())) { return false;