Merge pull request #301 from MiroPalmu/master

Fixes two mistakes in comments and removes one unused vk::MappedMemoryRange
This commit is contained in:
Alejandro Saucedo 2022-09-11 10:25:42 +01:00 committed by GitHub
commit e8f051fc66
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 9 deletions

View file

@ -12,16 +12,15 @@ git clone --branch 3.2 https://github.com/godotengine/godot-cpp
cd godot-cpp
```
Then we can get all the subomdules
Then we can get all the submodules
```
git submodule sync
```
and we build the bindings
And we build the bindings
```
scons -j16 platform=linuxbsd target=debug
```

View file

@ -132,7 +132,6 @@ Tensor::mapRawData()
this->mRawData = this->mDevice->mapMemory(
*hostVisibleMemory, 0, bufferSize, vk::MemoryMapFlags());
vk::MappedMemoryRange mappedMemoryRange(*hostVisibleMemory, 0, bufferSize);
}
void
@ -241,7 +240,7 @@ Tensor::recordStagingBufferMemoryBarrier(const vk::CommandBuffer& commandBuffer,
vk::PipelineStageFlagBits srcStageMask,
vk::PipelineStageFlagBits dstStageMask)
{
KP_LOG_DEBUG("Kompute Tensor recording PRIMARY buffer memory barrier");
KP_LOG_DEBUG("Kompute Tensor recording STAGING buffer memory barrier");
this->recordBufferMemoryBarrier(commandBuffer,
*this->mStagingBuffer,

View file

@ -217,16 +217,12 @@ class Sequence : public std::enable_shared_from_this<Sequence>
/**
* Begins recording commands for commands to be submitted into the command
* buffer.
*
* @return Boolean stating whether execution was successful.
*/
void begin();
/**
* Ends the recording and stops recording commands when the record command
* is sent.
*
* @return Boolean stating whether execution was successful.
*/
void end();