From 63b0b8a4aee22c3367df7e5f2930fce351eeb061 Mon Sep 17 00:00:00 2001 From: Miro Palmu Date: Sat, 10 Sep 2022 18:44:26 +0300 Subject: [PATCH 1/3] Fixed documentation Signed-off-by: Miro Palmu --- src/include/kompute/Sequence.hpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/include/kompute/Sequence.hpp b/src/include/kompute/Sequence.hpp index 544344f14..56dbcd6bc 100644 --- a/src/include/kompute/Sequence.hpp +++ b/src/include/kompute/Sequence.hpp @@ -217,16 +217,12 @@ class Sequence : public std::enable_shared_from_this /** * Begins recording commands for commands to be submitted into the command * buffer. - * - * @return Boolean stating whether execution was successful. */ void begin(); /** * Ends the recording and stops recording commands when the record command * is sent. - * - * @return Boolean stating whether execution was successful. */ void end(); From d52b3d41b8eb4339e5aaac6036aa2f6bb40ba7e4 Mon Sep 17 00:00:00 2001 From: Miro Palmu Date: Sat, 10 Sep 2022 18:47:00 +0300 Subject: [PATCH 2/3] Fixed typo Signed-off-by: Miro Palmu --- src/Tensor.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Tensor.cpp b/src/Tensor.cpp index 4f5e866f9..7a337503b 100644 --- a/src/Tensor.cpp +++ b/src/Tensor.cpp @@ -132,7 +132,6 @@ Tensor::mapRawData() this->mRawData = this->mDevice->mapMemory( *hostVisibleMemory, 0, bufferSize, vk::MemoryMapFlags()); - vk::MappedMemoryRange mappedMemoryRange(*hostVisibleMemory, 0, bufferSize); } void @@ -241,7 +240,7 @@ Tensor::recordStagingBufferMemoryBarrier(const vk::CommandBuffer& commandBuffer, vk::PipelineStageFlagBits srcStageMask, vk::PipelineStageFlagBits dstStageMask) { - KP_LOG_DEBUG("Kompute Tensor recording PRIMARY buffer memory barrier"); + KP_LOG_DEBUG("Kompute Tensor recording STAGING buffer memory barrier"); this->recordBufferMemoryBarrier(commandBuffer, *this->mStagingBuffer, From 604f8849a013676a47fc44b990da6cf7b7e375e3 Mon Sep 17 00:00:00 2001 From: Miro Palmu Date: Sat, 10 Sep 2022 22:58:14 +0300 Subject: [PATCH 3/3] Commit from pr 294 Signed-off-by: Miro Palmu --- examples/godot_examples/gdnative_shared/README.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/examples/godot_examples/gdnative_shared/README.md b/examples/godot_examples/gdnative_shared/README.md index f3a06bfbd..4ead74938 100644 --- a/examples/godot_examples/gdnative_shared/README.md +++ b/examples/godot_examples/gdnative_shared/README.md @@ -12,16 +12,15 @@ git clone --branch 3.2 https://github.com/godotengine/godot-cpp cd godot-cpp ``` -Then we can get all the subomdules +Then we can get all the submodules ``` git submodule sync ``` -and we build the bindings +And we build the bindings ``` scons -j16 platform=linuxbsd target=debug ``` -