Commit graph

35884 commits

Author SHA1 Message Date
Viktor Szakats
93b733ec97
try fix 3 2025-08-18 11:20:16 +02:00
Viktor Szakats
427d56e9c0
try fix 2 2025-08-18 11:20:16 +02:00
Viktor Szakats
c2931a2bc1
try fix 2025-08-18 11:20:16 +02:00
Viktor Szakats
977ac07924
cleanup 2025-08-18 11:20:16 +02:00
Viktor Szakats
90fcd83b96
drop debug 1 2025-08-18 11:20:16 +02:00
Viktor Szakats
3f13439222
fixup 2025-08-18 11:20:16 +02:00
Viktor Szakats
a9e8c0f221
debug 1 2025-08-18 11:20:16 +02:00
Viktor Szakats
6e8a8afa40
fixups 2025-08-18 11:20:16 +02:00
Viktor Szakats
0c69990174
debug 1 2025-08-18 11:20:16 +02:00
Viktor Szakats
e0d27e7595
backtrack 2025-08-18 11:20:16 +02:00
Viktor Szakats
ea4e0732c0
fixups 2025-08-18 11:20:16 +02:00
Viktor Szakats
b7a9650d94
try-sth-2 2025-08-18 11:20:16 +02:00
Viktor Szakats
3891dab7d6
Enterprise 2025-08-18 11:20:16 +02:00
Viktor Szakats
820bfa13b5
Revert "try-sth-1"
This reverts commit cedb3f3d4c4e9e334055016c6786715fea21c0b9.
2025-08-18 11:20:16 +02:00
Viktor Szakats
e8642937b0
try-sth-1 2025-08-18 11:20:16 +02:00
Viktor Szakats
180ebe5d36
fixup 2025-08-18 11:20:16 +02:00
Viktor Szakats
3fa5051def
fixup 2025-08-18 11:20:16 +02:00
Viktor Szakats
f8c43ce046
configure MSVC for Ninja manually 2025-08-18 11:20:16 +02:00
Viktor Szakats
7ecb0895ef
fixup 2025-08-18 11:20:16 +02:00
Viktor Szakats
419ca2f143
limit ninja to native x64 targets only 2025-08-18 11:20:16 +02:00
Viktor Szakats
3cc774874b
GHA/windows: switch to Ninja to MSVC jobs running tests 2 2025-08-18 11:20:16 +02:00
Viktor Szakats
f843cacb08
GHA/windows: try switching to Ninja to MSVC jobs running tests 1 2025-08-18 11:20:16 +02:00
Viktor Szakats
11bb681ce8
GHA/windows: tidy up running find in two build steps
Cherry-picked from #18301
2025-08-18 11:19:50 +02:00
Viktor Szakats
a19bd43210
cmake: honor CMAKE_C_FLAGS in test 1119 and 1167
`CMAKE_C_FLAGS` is not set by curl, but may contain custom options
required for a successful compiler run, when invoked by these tests.

One such case is when configuring Visual Studio or clang-cl via compiler
options, instead of envs.

Cherry-picked from #18301
Closes #18307
2025-08-18 11:08:53 +02:00
Daniel Stenberg
294ebba565
bufq: simplify condition
'result' is always CURLE_AGAIN here

Pointed out by CodeSonar

Closes #18305
2025-08-18 09:58:31 +02:00
Daniel Stenberg
e440686034
ftp: use 'conn' instead of 'data->conn'
In the ftp_state_use_port function, as we already use that local
variable for all other conn accesses.

Closes #18304
2025-08-18 09:57:45 +02:00
Daniel Stenberg
435069fcd9
RELEASE-NOTES: synced 2025-08-17 22:56:48 +02:00
Daniel Stenberg
0ba8e7f9db
test1549: verify CURLOPT_COOKIEFILE after expired cookies
Verifies #18299 (de89b86046)
Closes #18303
2025-08-17 22:52:18 +02:00
xfangfang
de89b86046
cookie: remove expired cookies before listing
Closes #18299
2025-08-17 22:25:25 +02:00
Stefan Eissing
a5f0ab7995
openssl: auto-pause on verify callback retry
When an application install its own OpenSSL verify callback and that
callback invokes `SSL_set_retry_verify()`, the transfer is automatically
paused and does not progress the connect attempt any further until
unpaused via `curl_easy_pause().

Added test758 to verify.

Ref: #18284
Original PR by @Natris
Bug: https://curl.se/mail/lib-2025-08/0012.html
Closes #18288
2025-08-15 13:50:28 +02:00
Daniel Stenberg
c5f76b8096
sendf: getting less data than "max allowed" is okay
Easily triggered when doing an FTP ranged download with the end range
larger than the file size.

A regression since 30de937bda (shipped in curl 8.9.0)

Add test 2307 to verify.

Reported-by: kupavcevdenis on github
Fixes #18283
Closes #18295
2025-08-15 13:35:04 +02:00
Daniel Stenberg
b2294996b6
CURLOPT_SSL_CTX_*: replace the base64 with XXXX
- they are fake anyway
- these ones look more obvious fake and in need of replacement
- avoids the risk that they might decode to something of value

Closes #18261
2025-08-15 09:39:44 +02:00
Daniel Stenberg
ecf12d4464
docs/examples: remove spurious trailing backslashes
Unnecessary clutter

Follow-up to d06b49d8b2

Closes #18289
2025-08-15 09:37:14 +02:00
Daniel Stenberg
9fc30567bf
RELEASE-NOTES: synced 2025-08-15 09:29:47 +02:00
Viktor Szakats
35a3b256f3
GHA/linux: skip building examples in valgrind jobs
To make these long jobs finish a little bit faster.

10s in total for 5 cmake jobs, 11s for 1 autotools job.

Closes #18291
2025-08-14 21:02:33 +02:00
Viktor Szakats
596383ca71
GHA/linux: try improving valgrind job times with cmake
Make the:
- mbedTLS valgrind job finish under 14m, vs 15m before.
- OpenSSL -O3 valgrind job finish in 14m30, vs 16m17.
- OpenSSL libssh2 valgrind job finish in 16m, vs 17m30.
- long valgrind rustls job finish 1 minute earlier, in return
  for spending 30s more on the other rustls job.

Keep using autotools for the less slow valgrind job to test this combo.

Closes #18290
2025-08-14 20:10:16 +02:00
Viktor Szakats
be01b60ce5
runtests: assume Time::HiRes, drop Perl Win32 dependency
`Time::HiRes` was already used unconditionally before this patch in
`servers.pm`. This package, and functions used by runtests (`sleep` and
`gettimeofday`) are supported by the minimum Perl version required for
curl:

https://perldoc.perl.org/5.8.0/Time::HiRes

- Drop the `portable_sleep()` wrapper in favor of `Time::HiRes::sleep()`.
- Use `Time::HiRes` unconditionally in `serverhelp.pm`.
- Stop using the `Win32` package where available. It was included
  to provide a Windows fallback for `Time::HiRes::sleep()`. It was never
  actually called, but the dependency may have loaded `Win32.dll`, which
  often appears in failed fork operations in GHA logs.
  Ref: a6fed41f6f #5054 #5034
  Ref: https://github.com/curl/curl/discussions/14854

Closes #18287
2025-08-14 16:34:06 +02:00
Viktor Szakats
c24d4be057
processhelp.pm: fix to use the correct null device on Windows
To not create a file named `nul` in the `tests` directory when running
tests with MSYS2/Cygwin Perl (the only supported Perl for Windows).

I imagine this may cause issues when being written in parallel. Also
`nul` is a reserved filename on Windows.

Closes #18282
2025-08-14 12:25:15 +02:00
Viktor Szakats
d63e40f8e6
mbedtls: check for feature macros instead of version
Drop three interim macros and mbedTLS version checks in favor of feature
macros defined by mbedTLS itself.

These mbedTLS features require mbedTLS 3.6.0/3.6.1 for production.
Earlier versions may have partial/experimental support for them,
disabled by default and (AFAICS) without documented build options
to enable them.

One feature guard already used the native macro instead of the interim
one before this patch. (`MBEDTLS_SSL_SESSION_TICKETS`)

Ref: https://github.com/curl/curl/pull/18254#issuecomment-3182668817

Closes #18271
2025-08-14 12:25:14 +02:00
renovate[bot]
d10880eac8
Dockerfile: update debian:bookworm-slim Docker digest to b1a7414
Closes #18270
2025-08-14 10:32:59 +02:00
Daniel Stenberg
16ddcd6712
wolfssh: move the sftp upload init out of the state machine
Into its own function to reduce complexity. Takes complexity down from
72 to 50.

Closes #18278
2025-08-14 08:58:59 +02:00
Daniel Stenberg
adb0fa737d
socks5: split out two functions from the SOCKS5 state machine
Complexity down from 74 to 59

Closes #18277
2025-08-14 08:57:07 +02:00
Viktor Szakats
3eb00fa795
openssl: save and restore OpenSSL error queue in two functions
After merging #18228, I reviewed whether the clearing of the error queue
may interfere with preceding code. Turns out there may be a preceding
`SSL_Connect()` call.

This patch replaces the previous fix of clearing the error queue with
saving and restoring it in two functions which may be called between
the connect call and the `SSL_get_error()` call following it:
- `ossl_log_tls12_secret()`
- `Curl_ssl_setup_x509_store()`

The `ERR_set_mark()`, `ERR_pop_to_mark()` functions are present in all
supported OpenSSL and LibreSSL versions. Also in BoringSSL since its
initial commit.

OpenSSL may modify its error queue in all API calls that can fail.

Thanks-to: Viktor Dukhovni
Ref: https://github.com/curl/curl/issues/18190#issuecomment-3167702142
Ref: https://github.com/curl/curl/issues/18190#issuecomment-3169211739
Ref: https://github.com/curl/curl/issues/18190#issuecomment-3169988050

Follow-up to 8ec241bc99 #18228 #18190
Ref: e8b00fcd6a #10432 #10389
Fixes #18190
Closes #18234
2025-08-13 18:54:08 +02:00
Viktor Szakats
2a46df31fd
GHA/linux: fix thread sanitizer error output
Replace autotools with cmake to avoid libtool wrappers that are changing
`LD_LIBRARY_PATH` in a way incompatible with the thread sanitizer.

To fix the output when the sanitizier is finding something:
```
==51718==WARNING: Can't write to symbolizer at fd 7
 /usr/bin/llvm-symbolizer-18: /home/runner/work/curl/curl/bld/lib/.libs/libcurl.so.4: no version information available (required by /usr/bin/llvm-symbolizer-18)
 /usr/bin/llvm-symbolizer-18: symbol lookup error: /home/runner/openssl/lib/libcrypto.so.3: undefined symbol: __tsan_func_entry
```
Ref: https://github.com/curl/curl/actions/runs/16911402500/job/47913783729#step:39:4466

After:
```
 13:50:04.117885 == Info:ThreadSanitizer: thread T1  finished with ignores enabled, created at:
  closing connection #0
     #0 pthread_create <null> (libtests+0x6bc0f) (BuildId: 4fe889446291259934205ac03931c397aa0210d3)
     #1 Curl_thread_create /home/runner/work/curl/curl/lib/curl_threads.c:73:6 (libcurl.so.4+0x55a76) (BuildId: cb0f14ba2ad68c9cab0c980d9a5d7a53cc0782da)
     #2 async_thrdd_init /home/runner/work/curl/curl/lib/asyn-thrdd.c:500:26 (libcurl.so.4+0x1c153) (BuildId: cb0f14ba2ad68c9cab0c980d9a5d7a53cc0782da)
[...]
```
Ref: https://github.com/curl/curl/actions/runs/16939193922/job/48003405272?pr=18274#step:39:4018

Also:
- disable memory tracker which turned out to be incompatible with
  the thread sanitizer and detaching threads.
  Ref: #18263 and #curl IRC.
- the job is ~30 seconds faster after this patch.

Reported-by: Stefan Eissing
Bug: https://github.com/curl/curl/pull/18263#issuecomment-3179279440
Follow-up to a2bcec0ee0 #14751
Closes #18274
2025-08-13 18:34:22 +02:00
Jelle Raaijmakers
a401421d46
CURLOPT_HTTP_VERSION: mention new default value
Fixes #18272
Cloes #18273
2025-08-13 15:03:35 +02:00
Viktor Szakats
01a2308236
mbedtls: bump minimum version required to 3.2.0
3.2.0 was released on July 11, 2022.

Ref: #18161
Closes #18254
2025-08-13 09:09:45 +02:00
renovate[bot]
357e6cfd57
GHA: update awslabs/aws-lc to v1.58.0
Closes #18269
2025-08-13 08:50:28 +02:00
renovate[bot]
e8edc9d840
Dockerfile: update debian:bookworm-slim Docker digest to 135c31f
Closes #18268
2025-08-13 08:49:38 +02:00
Daniel Stenberg
c6ae07c6a5
cookie: don't treat the leading slash as trailing
If there is only a leading slash in the path, keep that. Also add an
assert to make sure the path is never blank.

Reported-by: Google Big Sleep
Closes #18266
2025-08-13 01:00:28 +02:00
Daniel Stenberg
f6f62933e9
examples: remove href_extractor.c
The library this seems to refer to is no longer there.

Closes #18264
2025-08-12 14:02:43 +02:00