romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-05-30 07:57:27 +03:00
Code Issues Projects Releases Packages Wiki Activity

hsts: Remove single-use single-line function

Browse source 
The hsts_entry() function contains of a single line and is only
used in a single place in the code, so move the allocation into
hsts_create instead to improve code readability. C code usually
don't use the factory abstraction for object creation, and this
small example wasn't following our usual code style.

Closes: #13604
Reviewed-by: Daniel Stenberg <daniel@haxx.se>
This commit is contained in:
Daniel Gustafsson 2024-05-13 09:07:30 +02:00
parent a35bbe8977
commit 4d96873a4d
1 changed files with 1 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

7
lib/hsts.c
View file

@ -107,11 +107,6 @@ void Curl_hsts_cleanup(struct hsts **hp)
}
}
static struct stsentry *hsts_entry(void)
{
return calloc(1, sizeof(struct stsentry));
}
static CURLcode hsts_create(struct hsts *h,
const char *hostname,
bool subdomains,
@ -127,7 +122,7 @@ static CURLcode hsts_create(struct hsts *h,
--hlen;
if(hlen) {
char *duphost;
struct stsentry *sts = hsts_entry();
struct stsentry *sts = calloc(1, sizeof(struct stsentry));
if(!sts)
return CURLE_OUT_OF_MEMORY;