From 4d96873a4d50b3c16c280307dee91be01f1fdc0b Mon Sep 17 00:00:00 2001 From: Daniel Gustafsson Date: Mon, 13 May 2024 09:07:30 +0200 Subject: [PATCH] hsts: Remove single-use single-line function The hsts_entry() function contains of a single line and is only used in a single place in the code, so move the allocation into hsts_create instead to improve code readability. C code usually don't use the factory abstraction for object creation, and this small example wasn't following our usual code style. Closes: #13604 Reviewed-by: Daniel Stenberg --- lib/hsts.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/lib/hsts.c b/lib/hsts.c index d006e68869..72b80a46ca 100644 --- a/lib/hsts.c +++ b/lib/hsts.c @@ -107,11 +107,6 @@ void Curl_hsts_cleanup(struct hsts **hp) } } -static struct stsentry *hsts_entry(void) -{ - return calloc(1, sizeof(struct stsentry)); -} - static CURLcode hsts_create(struct hsts *h, const char *hostname, bool subdomains, @@ -127,7 +122,7 @@ static CURLcode hsts_create(struct hsts *h, --hlen; if(hlen) { char *duphost; - struct stsentry *sts = hsts_entry(); + struct stsentry *sts = calloc(1, sizeof(struct stsentry)); if(!sts) return CURLE_OUT_OF_MEMORY;