Fix more warnings and remove dead code

This commit is contained in:
Nicolas Werner 2021-12-28 22:30:12 +01:00
parent 409ff22d80
commit bb290f9fec
No known key found for this signature in database
GPG key ID: C8D75E610773F2D9
50 changed files with 276 additions and 695 deletions

View file

@ -317,7 +317,7 @@ RoomlistModel::addRoom(const QString &room_id, bool suppressInsertNotification)
int total_unread_msgs = 0;
for (const auto &room : models) {
for (const auto &room : qAsConst(models)) {
if (!room.isNull())
total_unread_msgs += room->notificationCount();
}
@ -586,8 +586,8 @@ RoomlistModel::initializeRooms()
}
invites = cache::client()->invites();
for (const auto &id : invites.keys()) {
roomids.push_back(id);
for (auto id = invites.keyBegin(); id != invites.keyEnd(); ++id) {
roomids.push_back(*id);
}
for (const auto &id : cache::client()->roomIds())
@ -826,10 +826,12 @@ FilteredRoomlistModel::updateHiddenTagsAndSpaces()
hiddenTags.clear();
hiddenSpaces.clear();
hideDMs = false;
for (const auto &t : UserSettings::instance()->hiddenTags()) {
if (t.startsWith("tag:"))
auto hidden = UserSettings::instance()->hiddenTags();
for (const auto &t : qAsConst(hidden)) {
if (t.startsWith(u"tag:"))
hiddenTags.push_back(t.mid(4));
else if (t.startsWith("space:"))
else if (t.startsWith(u"space:"))
hiddenSpaces.push_back(t.mid(6));
else if (t == "dm")
hideDMs = true;