From b47d51cb5af445e1b6fb3aa4c2958fe295413f5f Mon Sep 17 00:00:00 2001
From: Nicolas Werner <nicolas.werner@hotmail.de>
Date: Sun, 15 Jun 2025 19:39:03 +0200
Subject: [PATCH] Remove unused private fields

---
 src/JdenticonProvider.cpp | 13 +++----------
 src/JdenticonProvider.h   |  8 +++-----
 src/ui/MxcMediaProxy.h    |  5 ++---
 3 files changed, 8 insertions(+), 18 deletions(-)

diff --git a/src/JdenticonProvider.cpp b/src/JdenticonProvider.cpp
index 46d898ef..8edd6e45 100644
--- a/src/JdenticonProvider.cpp
+++ b/src/JdenticonProvider.cpp
@@ -61,22 +61,15 @@ clipRadius(QPixmap img, double radius)
     return out;
 }
 
-JdenticonResponse::JdenticonResponse(const QString &key,
-                                     bool crop,
-                                     double radius,
-                                     const QSize &requestedSize)
+JdenticonResponse::JdenticonResponse(const QString &key, double radius, const QSize &requestedSize)
 {
-    auto runnable = new JdenticonRunnable(key, crop, radius, requestedSize);
+    auto runnable = new JdenticonRunnable(key, radius, requestedSize);
     connect(runnable, &JdenticonRunnable::done, this, &JdenticonResponse::handleDone);
     QThreadPool::globalInstance()->start(runnable);
 }
 
-JdenticonRunnable::JdenticonRunnable(const QString &key,
-                                     bool crop,
-                                     double radius,
-                                     const QSize &requestedSize)
+JdenticonRunnable::JdenticonRunnable(const QString &key, double radius, const QSize &requestedSize)
   : m_key(key)
-  , m_crop{crop}
   , m_radius{radius}
   , m_requestedSize(requestedSize.isValid() ? requestedSize : QSize(100, 100))
 {
diff --git a/src/JdenticonProvider.h b/src/JdenticonProvider.h
index ba7c5023..f3b2c60f 100644
--- a/src/JdenticonProvider.h
+++ b/src/JdenticonProvider.h
@@ -15,7 +15,7 @@ class JdenticonRunnable final
 {
     Q_OBJECT
 public:
-    JdenticonRunnable(const QString &key, bool crop, double radius, const QSize &requestedSize);
+    JdenticonRunnable(const QString &key, double radius, const QSize &requestedSize);
 
     void run() override;
 
@@ -24,7 +24,6 @@ signals:
 
 private:
     QString m_key;
-    bool m_crop;
     double m_radius;
     QSize m_requestedSize;
 };
@@ -32,7 +31,7 @@ private:
 class JdenticonResponse final : public QQuickImageResponse
 {
 public:
-    JdenticonResponse(const QString &key, bool crop, double radius, const QSize &requestedSize);
+    JdenticonResponse(const QString &key, double radius, const QSize &requestedSize);
 
     QQuickTextureFactory *textureFactory() const override
     {
@@ -60,7 +59,6 @@ public slots:
     requestImageResponse(const QString &id, const QSize &requestedSize) override
     {
         auto id_      = id;
-        bool crop     = true;
         double radius = 0;
 
         auto queryStart = id.lastIndexOf('?');
@@ -76,6 +74,6 @@ public slots:
             }
         }
 
-        return new JdenticonResponse(id_, crop, radius, requestedSize);
+        return new JdenticonResponse(id_, radius, requestedSize);
     }
 };
diff --git a/src/ui/MxcMediaProxy.h b/src/ui/MxcMediaProxy.h
index 15606d36..4ec20099 100644
--- a/src/ui/MxcMediaProxy.h
+++ b/src/ui/MxcMediaProxy.h
@@ -92,7 +92,6 @@ private:
     QString eventId_;
     QString filename_;
     QBuffer buffer;
-    QObject *m_surface = nullptr;
-    float volume_      = 1.f;
-    bool muted_        = false;
+    float volume_ = 1.f;
+    bool muted_   = false;
 };