thek0tyara/nheko
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix nits from code review

Browse source
This commit is contained in:
kamathmanu 2021-08-09 09:18:08 -04:00
parent 2dfccda73c
commit 6a75e5270c
7 changed files with 7 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/RoomDirectoryModel.cpp
View file

@ -42,9 +42,7 @@ RoomDirectoryModel::resetDisplayedData()
nextBatch_ = "";
canFetchMore_ = true;
beginRemoveRows(QModelIndex(), 0, static_cast<int>(publicRoomsData_.size()));
publicRoomsData_.clear();
endRemoveRows();
endResetModel();
}
@ -87,8 +85,7 @@ RoomDirectoryModel::getViasForRoom(const std::vector<std::string> &aliases)
std::transform(
aliases.begin(), aliases.end(), std::back_inserter(vias), [](const auto &alias) {
const auto roomAliasDelimiter = ":";
return alias.substr(alias.find(roomAliasDelimiter) + 1);
return alias.substr(alias.find(":") + 1);
});
return vias;

1
src/RoomDirectoryModel.h
View file

@ -51,7 +51,6 @@ public:
inline bool canFetchMore(const QModelIndex &) const override
{
nhlog::net()->debug("determining if can fetch more");
return canFetchMore_;
}
void fetchMore(const QModelIndex &) override;

2
src/timeline/TimelineViewManager.cpp
View file

@ -287,7 +287,7 @@ TimelineViewManager::TimelineViewManager(CallManager *callManager, ChatPage *par
"Error: Only enums");
qmlRegisterType<RoomDirectoryModel>(
"im.nheko.RoomDirectoryModel", 1, 0, "RoomDirectoryModel");
"im.nheko", 1, 0, "RoomDirectoryModel");
#ifdef USE_QUICK_VIEW
view = new QQuickView(parent);