Private linking when ever possible

Signed-off-by: Fabian Sauter <sauter.fabian@mailbox.org>
This commit is contained in:
Fabian Sauter 2022-05-20 16:17:55 +02:00
parent f01bcb68a5
commit f0773d6005
2 changed files with 8 additions and 9 deletions

View file

@ -47,7 +47,7 @@ if(CPR_FORCE_USE_SYSTEM_CURL)
install(EXPORT komputeTargets
FILE komputeTargets.cmake
NAMESPACE kompute::
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/kompute)
DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/kompute)
install(FILES ${PROJECT_BINARY_DIR}/kompute/komputeConfig.cmake
${PROJECT_BINARY_DIR}/kompute/komputeConfigVersion.cmake DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/kompute)
@ -81,14 +81,13 @@ endif()
if(KOMPUTE_OPT_ANDROID_BUILD)
target_link_libraries(kompute PUBLIC kompute_vk_ndk_wrapper
fmt::fmt
log
android
logger)
PRIVATE logger
fmt::fmt)
else()
target_link_libraries(kompute PUBLIC Vulkan::Vulkan
fmt::fmt
logger)
PRIVATE fmt::fmt
logger)
endif()
if(KOMPUTE_OPT_USE_BUILD_IN_VULKAN_HEADER)

View file

@ -15,9 +15,9 @@ macro(add_kompute_test _TEST_NAME)
add_executable("${_TEST_NAME}_tests" "Test${_TEST_NAME}.cpp"
${ARGN})
target_link_libraries("${_TEST_NAME}_tests" PRIVATE GTest::GTest
kompute::kompute
test_shaders
test_shaders_glsl)
kompute::kompute
test_shaders
test_shaders_glsl)
add_test(NAME "kompute_${_TEST_NAME}_tests" COMMAND "${_TEST_NAME}_tests")
# Group under the "tests" project folder in IDEs such as Visual Studio.
set_property(TARGET ${_TEST_NAME}_tests PROPERTY FOLDER "tests")