From 5e23eb7fdb15b869cacdd6def364035dac93bb24 Mon Sep 17 00:00:00 2001 From: Alejandro Saucedo Date: Wed, 13 Apr 2022 11:05:10 +0100 Subject: [PATCH] Added log level only on compile flag Signed-off-by: Alejandro Saucedo --- CMakeLists.txt | 6 ------ docs/overview/build-system.rst | 2 -- 2 files changed, 8 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index db36e29b8..83f2b27c0 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -18,7 +18,6 @@ option(KOMPUTE_OPT_INSTALL "Enable if you want to enable installation" 0) # Build options option(KOMPUTE_OPT_BUILD_PYTHON "Enable if you want to build python bindings" 0) option(KOMPUTE_OPT_ENABLE_SPDLOG "Enable to compile with spdlog as the internal logging framework" 0) -option(KOMPUTE_OPT_LOG_LEVEL "Provides configuration option for log level 0-7 (debug, info, warn, etc)" -1) option(KOMPUTE_OPT_REPO_SUBMODULE_BUILD "Use the submodule repos instead of external package manager" 0) option(KOMPUTE_OPT_ANDROID_BUILD "Enable android compilation flags required" 0) option(KOMPUTE_OPT_DISABLE_VK_DEBUG_LAYERS "Explicitly disable debug layers even on debug" 0) @@ -27,11 +26,6 @@ option(KOMPUTE_OPT_BUILD_AS_SHARED_LIB "Whether to build kompute as shared libra # Build flags set(KOMPUTE_EXTRA_CXX_FLAGS "" CACHE STRING "Extra compile flags for Kompute, see docs for full list") -# If kompute log level greater or equal to 0 then set flag -if(NOT (KOMPUTE_OPT_LOG_LEVEL LESS 0)) - set(KOMPUTE_EXTRA_CXX_FLAGS "${KOMPUTE_EXTRA_CXX_FLAGS} -DKOMPUTE_LOG_LEVEL=${KOMPUTE_OPT_LOG_LEVEL}") -endif() - if(KOMPUTE_OPT_ENABLE_SPDLOG) set(KOMPUTE_EXTRA_CXX_FLAGS "${KOMPUTE_EXTRA_CXX_FLAGS} -DKOMPUTE_ENABLE_SPDLOG=1") set(SPDLOG_FMT_EXTERNAL ON CACHE BOOL "Enables external fmt as its current dep" FORCE) diff --git a/docs/overview/build-system.rst b/docs/overview/build-system.rst index a7b0698ce..ddb84ebda 100644 --- a/docs/overview/build-system.rst +++ b/docs/overview/build-system.rst @@ -37,8 +37,6 @@ This by default configures without any of the extra build tasks (such as buildin - Enable to build python bindings (used internally for python package) * - -DKOMPUTE_OPT_ENABLE_SPDLOG=1 - Enable to compile with spdlog as the internal logging framework - * - -DKOMPUTE_OPT_LOG_LEVEL=1 - - Provides configuration option for log level 0-7 (debug, info, warn, etc) * - -DKOMPUTE_OPT_REPO_SUBMODULE_BUILD=1 - Use the submodule repos instead of external packages / manager * - -DKOMPUTE_OPT_ANDROID_BUILD=1