From 4ad74665620a55699dd7c49e2a99ff3128ddfa72 Mon Sep 17 00:00:00 2001 From: Dudecake Date: Sun, 27 Sep 2020 18:01:09 +0200 Subject: [PATCH] Removed default arg before parameter pack --- single_include/kompute/Kompute.hpp | 2 +- src/include/kompute/Manager.hpp | 2 +- test/TestManager.cpp | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/single_include/kompute/Kompute.hpp b/single_include/kompute/Kompute.hpp index 757c637ec..a3afd44bf 100755 --- a/single_include/kompute/Kompute.hpp +++ b/single_include/kompute/Kompute.hpp @@ -792,7 +792,7 @@ class Manager */ template void evalOp(std::vector> tensors, - std::string sequenceName = KP_DEFAULT_SESSION, + std::string sequenceName, TArgs&&... params) { SPDLOG_DEBUG("Kompute Manager evalOp triggered"); diff --git a/src/include/kompute/Manager.hpp b/src/include/kompute/Manager.hpp index 44c6263cd..e3e522791 100644 --- a/src/include/kompute/Manager.hpp +++ b/src/include/kompute/Manager.hpp @@ -73,7 +73,7 @@ class Manager */ template void evalOp(std::vector> tensors, - std::string sequenceName = KP_DEFAULT_SESSION, + std::string sequenceName, TArgs&&... params) { SPDLOG_DEBUG("Kompute Manager evalOp triggered"); diff --git a/test/TestManager.cpp b/test/TestManager.cpp index 56687a252..1550d8efb 100644 --- a/test/TestManager.cpp +++ b/test/TestManager.cpp @@ -8,18 +8,18 @@ TEST(TestManager, EndToEndOpMultFlow) kp::Manager mgr; std::shared_ptr tensorLHS{ new kp::Tensor({ 0, 1, 2 }) }; - mgr.evalOp({ tensorLHS }); + mgr.evalOpDefault({ tensorLHS }); std::shared_ptr tensorRHS{ new kp::Tensor({ 2, 4, 6 }) }; - mgr.evalOp({ tensorRHS }); + mgr.evalOpDefault({ tensorRHS }); std::shared_ptr tensorOutput{ new kp::Tensor({ 0, 0, 0 }) }; - mgr.evalOp({ tensorOutput }); + mgr.evalOpDefault({ tensorOutput }); - mgr.evalOp>({ tensorLHS, tensorRHS, tensorOutput }); + mgr.evalOpDefault>({ tensorLHS, tensorRHS, tensorOutput }); - mgr.evalOp({ tensorOutput }); + mgr.evalOpDefault({ tensorOutput }); EXPECT_EQ(tensorOutput->data(), std::vector({ 0, 4, 12 })); }