romenskiy2012/jemalloc
1
0
Fork 0
mirror of https://github.com/jemalloc/jemalloc.git synced 2026-08-25 08:33:38 +03:00
Code Issues Projects Releases Packages Wiki Activity

Optimize ExtractSymbols (pprof).

Browse source 
Modify ExtractSymbols to operate on sorted PCs and libraries, in order
to reduce computational complexity from O(N*M) to O(N+M).
This commit is contained in:
Jason Evans 2010-04-02 18:43:28 -07:00
parent a53610130d
commit ec5344eba2
1 changed files with 19 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

25
jemalloc/bin/pprof
View file

@ -3681,8 +3681,17 @@ sub ExtractSymbols {
my $symbols = {}; my $symbols = {};
# Map each PC value to the containing library # Map each PC value to the containing library
my %seen = (); my @pcs = (sort { $a cmp $b } keys(%{$pcset}));
foreach my $lib (@{$libs}) { my @slibs = (sort {$a->[1] cmp $b->[1]} @{$libs});
my $bin = shift(@slibs);
if ($bin->[1] == 0) {
# Move binary to end (starts at address 0).
push(@slibs, $bin);
} else {
unshift(@slibs, $bin);
}
my $pc = shift(@pcs);
foreach my $lib (@slibs) {
my $libname = $lib->[0]; my $libname = $lib->[0];
my $start = $lib->[1]; my $start = $lib->[1];
my $finish = $lib->[2]; my $finish = $lib->[2];
@ -3690,14 +3699,18 @@ sub ExtractSymbols {
# Get list of pcs that belong in this library. # Get list of pcs that belong in this library.
my $contained = []; my $contained = [];
foreach my $pc (keys(%{$pcset})) { while (($pc ge $start) && ($pc le $finish)) {
if (!$seen{$pc} && ($pc ge $start) && ($pc le $finish)) { push(@{$contained}, $pc);
$seen{$pc} = 1; $pc = shift(@pcs);
push(@{$contained}, $pc); if (!defined $pc) {
last;
} }
} }
# Map to symbols # Map to symbols
MapToSymbols($libname, AddressSub($start, $offset), $contained, $symbols); MapToSymbols($libname, AddressSub($start, $offset), $contained, $symbols);
if (!defined $pc) {
last;
}
} }
return $symbols; return $symbols;