romenskiy2012/jemalloc
1
0
Fork 0
mirror of https://github.com/jemalloc/jemalloc.git synced 2026-04-14 14:41:42 +03:00
Code Issues Projects Releases Packages Wiki Activity

Add TODO to benchmark possibly better policy

Browse source
This commit is contained in:
Slobodan Predolac 2026-03-27 13:54:15 -07:00
parent 6281482c39
commit db7d99703d
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/sec.c
View file

@ -130,13 +130,17 @@ sec_multishard_trylock_alloc(
cur_shard = 0; cur_shard = 0;
} }
} }
/* No bin had alloc or had the extent */ /*
* TODO: Benchmark whether it is worth blocking on all shards here before
* declaring a miss. That could recover more remote-shard hits under
* contention, but it also changes the allocation latency policy.
*/
assert(cur_shard == sec_shard_pick(tsdn, sec)); assert(cur_shard == sec_shard_pick(tsdn, sec));
bin = sec_bin_pick(sec, cur_shard, pszind); bin = sec_bin_pick(sec, cur_shard, pszind);
malloc_mutex_lock(tsdn, &bin->mtx); malloc_mutex_lock(tsdn, &bin->mtx);
edata_t *edata = sec_bin_alloc_locked(tsdn, sec, bin, size); edata_t *edata = sec_bin_alloc_locked(tsdn, sec, bin, size);
if (edata == NULL) { if (edata == NULL) {
/* Only now we know it is a miss */ /* Only now we know it is a miss. */
bin->stats.nmisses++; bin->stats.nmisses++;
} }
malloc_mutex_unlock(tsdn, &bin->mtx); malloc_mutex_unlock(tsdn, &bin->mtx);