Add experimental prefix to hpa_strict_min_purge_interval

Goal is to make it obvious this option is experimental.
This commit is contained in:
Dmitry Ilvokhin 2024-08-19 10:54:19 -07:00 committed by Qi Wang
parent aaa29003ab
commit c7ccb8d7e9
8 changed files with 21 additions and 19 deletions

View file

@ -34,7 +34,7 @@ static hpa_shard_opts_t test_hpa_shard_opts_default = {
10 * 1000,
/* min_purge_interval_ms */
5 * 1000,
/* strict_min_purge_interval */
/* experimental_strict_min_purge_interval */
false,
/* experimental_max_purge_nhp */
-1
@ -53,7 +53,7 @@ static hpa_shard_opts_t test_hpa_shard_opts_purge = {
0,
/* min_purge_interval_ms */
5 * 1000,
/* strict_min_purge_interval */
/* experimental_strict_min_purge_interval */
false,
/* experimental_max_purge_nhp */
-1
@ -506,7 +506,7 @@ TEST_BEGIN(test_purge_no_infinite_loop) {
}
TEST_END
TEST_BEGIN(test_strict_no_min_purge_interval) {
TEST_BEGIN(test_no_experimental_strict_min_purge_interval) {
test_skip_if(!hpa_supported());
hpa_hooks_t hooks;
@ -547,7 +547,7 @@ TEST_BEGIN(test_strict_no_min_purge_interval) {
}
TEST_END
TEST_BEGIN(test_strict_min_purge_interval) {
TEST_BEGIN(test_experimental_strict_min_purge_interval) {
test_skip_if(!hpa_supported());
hpa_hooks_t hooks;
@ -561,7 +561,7 @@ TEST_BEGIN(test_strict_min_purge_interval) {
hpa_shard_opts_t opts = test_hpa_shard_opts_default;
opts.deferral_allowed = true;
opts.strict_min_purge_interval = true;
opts.experimental_strict_min_purge_interval = true;
hpa_shard_t *shard = create_test_data(&hooks, &opts);
@ -741,8 +741,8 @@ main(void) {
test_alloc_dalloc_batch,
test_defer_time,
test_purge_no_infinite_loop,
test_strict_no_min_purge_interval,
test_strict_min_purge_interval,
test_no_experimental_strict_min_purge_interval,
test_experimental_strict_min_purge_interval,
test_purge,
test_experimental_max_purge_nhp);
}

View file

@ -1,4 +1,4 @@
#!/bin/sh
export MALLOC_CONF="hpa_dirty_mult:0.001,hpa_hugification_threshold_ratio:1.0,hpa_min_purge_interval_ms:50,hpa_strict_min_purge_interval:true,hpa_sec_nshards:0"
export MALLOC_CONF="hpa_dirty_mult:0.001,hpa_hugification_threshold_ratio:1.0,hpa_min_purge_interval_ms:50,hpa_sec_nshards:0"

View file

@ -292,6 +292,8 @@ TEST_BEGIN(test_mallctl_opt) {
TEST_MALLCTL_OPT(size_t, hpa_sec_max_bytes, always);
TEST_MALLCTL_OPT(size_t, hpa_sec_bytes_after_flush, always);
TEST_MALLCTL_OPT(size_t, hpa_sec_batch_fill_extra, always);
TEST_MALLCTL_OPT(bool, experimental_hpa_strict_min_purge_interval,
always);
TEST_MALLCTL_OPT(ssize_t, experimental_hpa_max_purge_nhp, always);
TEST_MALLCTL_OPT(unsigned, narenas, always);
TEST_MALLCTL_OPT(const char *, percpu_arena, always);