romenskiy2012/jemalloc
1
0
Fork 0
mirror of https://github.com/jemalloc/jemalloc.git synced 2026-08-25 16:43:33 +03:00
Code Issues Projects Releases Packages Wiki Activity

Avoid creating bg thds for huge arena lone.

Browse source 
For low arena count settings, the huge threshold feature may trigger an unwanted
bg thd creation.  Given that the huge arena does eager purging by default,
bypass bg thd creation when initializing the huge arena.
This commit is contained in:
Qi Wang 2019-01-14 14:16:09 -08:00 • committed by Qi Wang
parent b6f1f2669a
commit bbe8e6a909
5 changed files with 43 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/jemalloc.c
View file

@ -344,12 +344,12 @@ arena_new_create_background_thread(tsdn_t *tsdn, unsigned ind) {
if (ind == 0) {
return;
}
if (have_background_thread) {
bool err;
malloc_mutex_lock(tsdn, &background_thread_lock);
err = background_thread_create(tsdn_tsd(tsdn), ind);
malloc_mutex_unlock(tsdn, &background_thread_lock);
if (err) {
/*
* Avoid creating a new background thread just for the huge arena, which
* purges eagerly by default.
*/
if (have_background_thread && !arena_is_huge(ind)) {
if (background_thread_create(tsdn_tsd(tsdn), ind)) {
malloc_printf("<jemalloc>: error in background thread "
"creation for arena %u. Abort.\n", ind);
abort();
@ -1719,11 +1719,7 @@ malloc_init_hard(void) {
* sets isthreaded) needs to be called without holding any lock.
*/
background_thread_ctl_init(tsd_tsdn(tsd));
malloc_mutex_lock(tsd_tsdn(tsd), &background_thread_lock);
bool err = background_thread_create(tsd, 0);
malloc_mutex_unlock(tsd_tsdn(tsd), &background_thread_lock);
if (err) {
if (background_thread_create(tsd, 0)) {
return true;
}
}