romenskiy2012/jemalloc
1
0
Fork 0
mirror of https://github.com/jemalloc/jemalloc.git synced 2026-04-14 14:41:42 +03:00
Code Issues Projects Releases Packages Wiki Activity

Option to guard hpa_min_purge_interval_ms fix

Browse source 
Change in `hpa_min_purge_interval_ms` handling logic is not backward
compatible as it might increase memory usage. Now this logic guarded by
`hpa_strict_min_purge_interval` option.

When `hpa_strict_min_purge_interval` is true, we will purge no more than
`hpa_min_purge_interval_ms`. When `hpa_strict_min_purge_interval` is
false, old purging logic behaviour is preserved.

Long term strategy migrate all users of hpa to new logic and then delete
`hpa_strict_min_purge_interval` option.
This commit is contained in:
Dmitry Ilvokhin 2024-06-07 05:32:24 -07:00 • committed by Qi Wang
parent 91a6d230db
commit 867c6dd7dc
6 changed files with 27 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
include/jemalloc/internal/hpa_opts.h
View file

@ -49,6 +49,14 @@ struct hpa_shard_opts_s {
* Minimum amount of time between purges.
*/
uint64_t min_purge_interval_ms;
/*
* Strictly respect minimum amout of time between purges.
*
* This is an option to provide backward compatibility for staged rollout of
* purging logic fix.
*/
bool strict_min_purge_interval;
};
#define HPA_SHARD_OPTS_DEFAULT { \
@ -69,7 +77,9 @@ struct hpa_shard_opts_s {
/* hugify_delay_ms */ \
10 * 1000, \
/* min_purge_interval_ms */ \
5 * 1000 \
5 * 1000, \
/* strict_min_purge_interval */ \
false \
}
#endif /* JEMALLOC_INTERNAL_HPA_OPTS_H */