romenskiy2012/jemalloc
1
0
Fork 0
mirror of https://github.com/jemalloc/jemalloc.git synced 2026-07-14 04:37:18 +03:00
Code Issues Projects Releases Packages Wiki Activity

Revert "Extend purging algorithm with peak demand tracking"

Browse source 
This reverts commit ad108d50f1.
This commit is contained in:
Jason Evans 2025-05-19 21:09:01 -07:00
parent edaab8b3ad
commit 27d7960cf9
20 changed files with 28 additions and 538 deletions
Download patch file Download diff file Expand all files Collapse all files

4
include/jemalloc/internal/hpa.h
View file

@ -10,7 +10,6 @@
#include "jemalloc/internal/hpa_opts.h"
#include "jemalloc/internal/mutex.h"
#include "jemalloc/internal/pai.h"
#include "jemalloc/internal/peak_demand.h"
#include "jemalloc/internal/psset.h"
typedef struct hpa_central_s hpa_central_t;
@ -148,9 +147,6 @@ struct hpa_shard_s {
* Last time we performed purge on this shard.
*/
nstime_t last_purge;
/* Peak active memory sliding window statistics. */
peak_demand_t peak_demand;
};
bool hpa_hugepage_size_exceeds_limit(void);

14
include/jemalloc/internal/hpa_opts.h
View file

@ -27,8 +27,7 @@ struct hpa_shard_opts_s {
/*
* The HPA purges whenever the number of pages exceeds dirty_mult *
* peak_active_pages. This may be set to (fxp_t)-1 to disable
* purging.
* active_pages. This may be set to (fxp_t)-1 to disable purging.
*/
fxp_t dirty_mult;
@ -60,13 +59,6 @@ struct hpa_shard_opts_s {
* Maximum number of hugepages to purge on each purging attempt.
*/
ssize_t experimental_max_purge_nhp;
/*
* Sliding window duration to track active memory demand statistics.
* This might be set to 0, to disable sliding window statistics
* tracking and use current number of active pages for purging instead.
*/
uint64_t peak_demand_window_ms;
};
/* clang-format off */
@ -92,9 +84,7 @@ struct hpa_shard_opts_s {
/* min_purge_interval_ms */ \
5 * 1000, \
/* experimental_max_purge_nhp */ \
-1, \
/* peak_demand_window_ms */ \
0 \
-1 \
}
/* clang-format on */

55
include/jemalloc/internal/peak_demand.h
View file

@ -1,55 +0,0 @@
#ifndef JEMALLOC_INTERNAL_PEAK_DEMAND_H
#define JEMALLOC_INTERNAL_PEAK_DEMAND_H
#include "jemalloc/internal/jemalloc_preamble.h"
/*
* Implementation of peak active memory demand tracking.
*
* Inspired by "Beyond malloc efficiency to fleet efficiency: a hugepage-aware
* memory allocator" whitepaper.
* https://storage.googleapis.com/gweb-research2023-media/pubtools/6170.pdf
*
* End goal is to track peak active memory usage over specified time interval.
* We do so by dividing this time interval into disjoint subintervals and
* storing value of maximum memory usage for each subinterval in a circular
* buffer. Nanoseconds resolution timestamp uniquely maps into epoch, which is
* used as an index to access circular buffer.
*/
#define PEAK_DEMAND_LG_BUCKETS 4
/*
* Number of buckets should be power of 2 to ensure modulo operation is
* optimized to bit masking by the compiler.
*/
#define PEAK_DEMAND_NBUCKETS (1 << PEAK_DEMAND_LG_BUCKETS)
typedef struct peak_demand_s peak_demand_t;
struct peak_demand_s {
/*
* Absolute value of current epoch, monotonically increases over time. Epoch
* value modulo number of buckets used as an index to access nactive_max
* array.
*/
uint64_t epoch;
/* How many nanoseconds each epoch approximately takes. */
uint64_t epoch_interval_ns;
/*
* Circular buffer to track maximum number of active pages for each
* epoch.
*/
size_t nactive_max[PEAK_DEMAND_NBUCKETS];
};
void peak_demand_init(peak_demand_t *peak_demand, uint64_t interval_ms);
/* Updates peak demand statistics with current number of active pages. */
void peak_demand_update(peak_demand_t *peak_demand, const nstime_t *now,
size_t nactive);
/* Returns maximum number of active pages in sliding window. */
size_t peak_demand_nactive_max(peak_demand_t *peak_demand);
#endif /* JEMALLOC_INTERNAL_PEAK_DEMAND_H */