romenskiy2012/jemalloc
1
0
Fork 0
mirror of https://github.com/jemalloc/jemalloc.git synced 2026-08-15 03:53:49 +03:00
Code Issues Projects Releases Packages Wiki Activity

Fix thread-exit TSD cleanup on MinGW builds

Browse source 
On MinGW, the legacy TlsAlloc TSD path has no thread-local variable, so the
linker omitted the PE TLS directory and never invoked the .CRT$XLY callback
(_tls_callback) on DLL_THREAD_DETACH. Per-thread TSD cleanup therefore never
ran on thread exit, and test_tsd_sub_thread failed with data_cleanup_count
== 0.

Reference _tls_used from tsd.c under __GNUC__ to force the CRT's TLS support
to be linked in, mirroring the existing MSVC /INCLUDE:_tls_used directive.
This commit is contained in:
Tony Printezis 2026-08-06 07:35:02 -07:00 • committed by Tony P
parent 1ec505b751
commit 1e92317014
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/tsd.c
View file

@ -393,6 +393,18 @@ _tls_callback(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) {
linker, "/INCLUDE:" STRINGIFY(tls_callback))
# endif
# pragma section(".CRT$XLY", long, read)
# elif defined(__GNUC__)
/*
* MinGW analog of the MSVC "/INCLUDE:_tls_used" directives above. Referencing
* _tls_used forces the linker to pull in the CRT's TLS support (tlssup), which
* emits the PE TLS directory so the loader actually invokes our .CRT$XLY
* callback (_tls_callback) on DLL_THREAD_DETACH. Without it, a statically
* linked MinGW binary (e.g. the unit tests) never runs per-thread TSD cleanup
* on thread exit. The compiler applies the correct symbol decoration, so this
* works for both 32- and 64-bit targets.
*/
extern char _tls_used;
JEMALLOC_ATTR(used) static char *const tls_used_ref = &_tls_used;
# endif
JEMALLOC_SECTION(".CRT$XLY")
JEMALLOC_ATTR(used) BOOL(WINAPI *const tls_callback)(