mirror of
https://github.com/curl/curl.git
synced 2026-05-19 12:36:20 +03:00
Before this patch curl used the C preprocessor to override standard memory allocation symbols: malloc, calloc, strdup, realloc, free. The goal of these is to replace them with curl's debug wrappers in `CURLDEBUG` builds, another was to replace them with the wrappers calling user-defined allocators in libcurl. This solution needed a bunch of workarounds to avoid breaking external headers: it relied on include order to do the overriding last. For "unity" builds it needed to reset overrides before external includes. Also in test apps, which are always built as single source files. It also needed the `(symbol)` trick to avoid overrides in some places. This would still not fix cases where the standard symbols were macros. It was also fragile and difficult to figure out which was the actual function behind an alloc or free call in a specific piece of code. This in turn caused bugs where the wrong allocator was accidentally called. To avoid these problems, this patch replaces this solution with `curlx_`-prefixed allocator macros, and mapping them _once_ to either the libcurl wrappers, the debug wrappers or the standard ones, matching the rest of the code in libtests. This concludes the long journey to avoid redefining standard functions in the curl codebase. Note: I did not update `packages/OS400/*.c` sources. They did not `#include` `curl_setup.h`, `curl_memory.h` or `memdebug.h`, meaning the overrides were never applied to them. This may or may not have been correct. For now I suppressed the direct use of standard allocators via a local `.checksrc`. Probably they (except for `curlcl.c`) should be updated to include `curl_setup.h` and use the `curlx_` macros. This patch changes mappings in two places: - `lib/curl_threads.c` in libtests: Before this patch it mapped to libcurl allocators. After, it maps to standard allocators, like the rest of libtests code. - `units`: before this patch it mapped to standard allocators. After, it maps to libcurl allocators. Also: - drop all position-dependent `curl_memory.h` and `memdebug.h` includes, and delete the now unnecessary headers. - rename `Curl_tcsdup` macro to `curlx_tcsdup` and define like the other allocators. - map `curlx_strdup()` to `_strdup()` on Windows (was: `strdup()`). To fix warnings silenced via `_CRT_NONSTDC_NO_DEPRECATE`. - multibyte: map `curlx_convert_*()` to `_strdup()` on Windows (was: `strdup()`). - src: do not reuse the `strdup` name for the local replacement. - lib509: call `_strdup()` on Windows (was: `strdup()`). - test1132: delete test obsoleted by this patch. - CHECKSRC.md: update text for `SNPRINTF`. - checksrc: ban standard allocator symbols. Follow-up tob12da22db1#18866 Follow-up todb98daab05#18844 Follow-up to4deea9396b#18814 Follow-up to9678ff5b1b#18776 Follow-up to10bac43b87#18774 Follow-up to20142f5d06#18634 Follow-up tobf7375ecc5#18503 Follow-up to9863599d69#18502 Follow-up to3bb5e58c10#17827 Closes #19626
203 lines
5.6 KiB
C
203 lines
5.6 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
|
|
#include "curl_setup.h"
|
|
|
|
#ifdef USE_WINDOWS_SSPI
|
|
|
|
#include <curl/curl.h>
|
|
#include "curl_sspi.h"
|
|
#include "strdup.h"
|
|
#include "curlx/multibyte.h"
|
|
#include "system_win32.h"
|
|
#include "curlx/warnless.h"
|
|
|
|
/* Pointer to SSPI dispatch table */
|
|
PSecurityFunctionTable Curl_pSecFn = NULL;
|
|
|
|
/*
|
|
* Curl_sspi_global_init()
|
|
*
|
|
* This is used to load the Security Service Provider Interface (SSPI)
|
|
* dynamic link library portably across all Windows versions, without
|
|
* the need to directly link libcurl, nor the application using it, at
|
|
* build time.
|
|
*
|
|
* Once this function has been executed, Windows SSPI functions can be
|
|
* called through the Security Service Provider Interface dispatch table.
|
|
*
|
|
* Parameters:
|
|
*
|
|
* None.
|
|
*
|
|
* Returns CURLE_OK on success.
|
|
*/
|
|
CURLcode Curl_sspi_global_init(void)
|
|
{
|
|
/* If security interface is not yet initialized try to do this */
|
|
if(!Curl_pSecFn) {
|
|
/* Get pointer to Security Service Provider Interface dispatch table */
|
|
Curl_pSecFn = InitSecurityInterface();
|
|
if(!Curl_pSecFn)
|
|
return CURLE_FAILED_INIT;
|
|
}
|
|
|
|
return CURLE_OK;
|
|
}
|
|
|
|
/*
|
|
* Curl_sspi_global_cleanup()
|
|
*
|
|
* This deinitializes the Security Service Provider Interface from libcurl.
|
|
*
|
|
* Parameters:
|
|
*
|
|
* None.
|
|
*/
|
|
void Curl_sspi_global_cleanup(void)
|
|
{
|
|
if(Curl_pSecFn) {
|
|
Curl_pSecFn = NULL;
|
|
}
|
|
}
|
|
|
|
/*
|
|
* Curl_create_sspi_identity()
|
|
*
|
|
* This is used to populate an SSPI identity structure based on the supplied
|
|
* username and password.
|
|
*
|
|
* Parameters:
|
|
*
|
|
* userp [in] - The username in the format User or Domain\User.
|
|
* passwdp [in] - The user's password.
|
|
* identity [in/out] - The identity structure.
|
|
*
|
|
* Returns CURLE_OK on success.
|
|
*/
|
|
CURLcode Curl_create_sspi_identity(const char *userp, const char *passwdp,
|
|
SEC_WINNT_AUTH_IDENTITY *identity)
|
|
{
|
|
xcharp_u useranddomain;
|
|
xcharp_u user, dup_user;
|
|
xcharp_u domain, dup_domain;
|
|
xcharp_u passwd, dup_passwd;
|
|
size_t domlen = 0;
|
|
|
|
domain.const_tchar_ptr = TEXT("");
|
|
|
|
/* Initialize the identity */
|
|
memset(identity, 0, sizeof(*identity));
|
|
|
|
useranddomain.tchar_ptr = curlx_convert_UTF8_to_tchar(userp);
|
|
if(!useranddomain.tchar_ptr)
|
|
return CURLE_OUT_OF_MEMORY;
|
|
|
|
user.const_tchar_ptr = _tcschr(useranddomain.const_tchar_ptr, TEXT('\\'));
|
|
if(!user.const_tchar_ptr)
|
|
user.const_tchar_ptr = _tcschr(useranddomain.const_tchar_ptr, TEXT('/'));
|
|
|
|
if(user.tchar_ptr) {
|
|
domain.tchar_ptr = useranddomain.tchar_ptr;
|
|
domlen = user.tchar_ptr - useranddomain.tchar_ptr;
|
|
user.tchar_ptr++;
|
|
}
|
|
else {
|
|
user.tchar_ptr = useranddomain.tchar_ptr;
|
|
domain.const_tchar_ptr = TEXT("");
|
|
domlen = 0;
|
|
}
|
|
|
|
/* Setup the identity's user and length */
|
|
dup_user.tchar_ptr = curlx_tcsdup(user.tchar_ptr);
|
|
if(!dup_user.tchar_ptr) {
|
|
curlx_unicodefree(useranddomain.tchar_ptr);
|
|
return CURLE_OUT_OF_MEMORY;
|
|
}
|
|
identity->User = dup_user.tbyte_ptr;
|
|
identity->UserLength = curlx_uztoul(_tcslen(dup_user.tchar_ptr));
|
|
dup_user.tchar_ptr = NULL;
|
|
|
|
/* Setup the identity's domain and length */
|
|
dup_domain.tchar_ptr = curlx_malloc(sizeof(TCHAR) * (domlen + 1));
|
|
if(!dup_domain.tchar_ptr) {
|
|
curlx_unicodefree(useranddomain.tchar_ptr);
|
|
return CURLE_OUT_OF_MEMORY;
|
|
}
|
|
if(_tcsncpy_s(dup_domain.tchar_ptr, domlen + 1, domain.tchar_ptr, domlen)) {
|
|
curlx_unicodefree(dup_domain.tchar_ptr);
|
|
curlx_unicodefree(useranddomain.tchar_ptr);
|
|
return CURLE_OUT_OF_MEMORY;
|
|
}
|
|
identity->Domain = dup_domain.tbyte_ptr;
|
|
identity->DomainLength = curlx_uztoul(domlen);
|
|
dup_domain.tchar_ptr = NULL;
|
|
|
|
curlx_unicodefree(useranddomain.tchar_ptr);
|
|
|
|
/* Setup the identity's password and length */
|
|
passwd.tchar_ptr = curlx_convert_UTF8_to_tchar(passwdp);
|
|
if(!passwd.tchar_ptr)
|
|
return CURLE_OUT_OF_MEMORY;
|
|
dup_passwd.tchar_ptr = curlx_tcsdup(passwd.tchar_ptr);
|
|
if(!dup_passwd.tchar_ptr) {
|
|
curlx_unicodefree(passwd.tchar_ptr);
|
|
return CURLE_OUT_OF_MEMORY;
|
|
}
|
|
identity->Password = dup_passwd.tbyte_ptr;
|
|
identity->PasswordLength = curlx_uztoul(_tcslen(dup_passwd.tchar_ptr));
|
|
dup_passwd.tchar_ptr = NULL;
|
|
|
|
curlx_unicodefree(passwd.tchar_ptr);
|
|
|
|
/* Setup the identity's flags */
|
|
identity->Flags = (unsigned long)
|
|
#ifdef UNICODE
|
|
SEC_WINNT_AUTH_IDENTITY_UNICODE;
|
|
#else
|
|
SEC_WINNT_AUTH_IDENTITY_ANSI;
|
|
#endif
|
|
|
|
return CURLE_OK;
|
|
}
|
|
|
|
/*
|
|
* Curl_sspi_free_identity()
|
|
*
|
|
* This is used to free the contents of an SSPI identifier structure.
|
|
*
|
|
* Parameters:
|
|
*
|
|
* identity [in/out] - The identity structure.
|
|
*/
|
|
void Curl_sspi_free_identity(SEC_WINNT_AUTH_IDENTITY *identity)
|
|
{
|
|
if(identity) {
|
|
Curl_safefree(identity->User);
|
|
Curl_safefree(identity->Password);
|
|
Curl_safefree(identity->Domain);
|
|
}
|
|
}
|
|
|
|
#endif /* USE_WINDOWS_SSPI */
|