mirror of
https://github.com/curl/curl.git
synced 2026-04-18 00:31:40 +03:00
2c27a67daa
Make test bundles the default. Drop non-bundle build mode.
Also do all the optimizations and tidy-ups this allows, simpler builds,
less bundle exceptions, streamlined build mechanics.
Also rework the init/deinit macro magic for unit tests. The new method
allows using unique init/deinit function names, and calling them with
arguments. This is in turn makes it possible to reduce the use of global
variables.
Note this drop existing build options `-DCURL_TEST_BUNDLES=` from cmake
and `--enable-test-bundles` / `--disable-test-bundles` from autotools.
Also:
- rename test entry functions to have unique names: `test_<testname>`
This removes the last exception that was handled in the generator.
- fix `make dist` to not miss test sources with test bundles enabled.
- sync and merge `tests/mk-bundle.pl` into `scripts/mk-unity.pl`.
- mk-unity.pl: add `--embed` option and use it when `CURL_CLANG_TIDY=ON`
to ensure that `clang-tidy` does not miss external test C sources.
(because `clang-tidy` ignores code that's #included.)
- tests/unit: drop no-op setup/stop functions.
- tests: reduce symbol scopes, global macros, other fixes and tidy-ups.
- tool1621: fix to run, also fix it to pass.
- sockfilt: fix Windows compiler warning in certain unity include order,
by explicitly including `warnless.h`.
Follow-up to 6897aeb105 #17468
Closes #17590
181 lines
7.1 KiB
C
181 lines
7.1 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "curlcheck.h"
|
|
|
|
#include <curlx.h>
|
|
#include "hash.h"
|
|
#include <memdebug.h> /* LAST include file */
|
|
|
|
static const size_t slots = 3;
|
|
|
|
static void t1603_mydtor(void *p)
|
|
{
|
|
/* Data are statically allocated */
|
|
(void)p; /* unused */
|
|
}
|
|
|
|
static size_t elem_dtor_calls;
|
|
|
|
static void my_elem_dtor(void *key, size_t key_len, void *p)
|
|
{
|
|
(void)p; /* unused */
|
|
(void)key; /* unused */
|
|
(void)key_len; /* unused */
|
|
++elem_dtor_calls;
|
|
}
|
|
|
|
static CURLcode t1603_setup(struct Curl_hash *hash_static)
|
|
{
|
|
Curl_hash_init(hash_static, slots, Curl_hash_str,
|
|
curlx_str_key_compare, t1603_mydtor);
|
|
return CURLE_OK;
|
|
}
|
|
|
|
static void t1603_stop(struct Curl_hash *hash_static)
|
|
{
|
|
Curl_hash_destroy(hash_static);
|
|
}
|
|
|
|
static CURLcode test_unit1603(char *arg)
|
|
{
|
|
struct Curl_hash hash_static;
|
|
|
|
UNITTEST_BEGIN(t1603_setup(&hash_static))
|
|
|
|
char key1[] = "key1";
|
|
char key2[] = "key2b";
|
|
char key3[] = "key3";
|
|
char key4[] = "key4";
|
|
char notakey[] = "notakey";
|
|
char *nodep;
|
|
int rc;
|
|
|
|
/* Ensure the key hashes are as expected in order to test both hash
|
|
collisions and a full table. Unfortunately, the hashes can vary
|
|
between architectures. */
|
|
if(Curl_hash_str(key1, strlen(key1), slots) != 1 ||
|
|
Curl_hash_str(key2, strlen(key2), slots) != 0 ||
|
|
Curl_hash_str(key3, strlen(key3), slots) != 2 ||
|
|
Curl_hash_str(key4, strlen(key4), slots) != 1)
|
|
curl_mfprintf(stderr,
|
|
"Warning: hashes are not computed as expected on this "
|
|
"architecture; test coverage will be less comprehensive\n");
|
|
|
|
nodep = Curl_hash_add(&hash_static, &key1, strlen(key1), &key1);
|
|
fail_unless(nodep, "insertion into hash failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key1, strlen(key1));
|
|
fail_unless(nodep == key1, "hash retrieval failed");
|
|
|
|
nodep = Curl_hash_add(&hash_static, &key2, strlen(key2), &key2);
|
|
fail_unless(nodep, "insertion into hash failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key2, strlen(key2));
|
|
fail_unless(nodep == key2, "hash retrieval failed");
|
|
|
|
nodep = Curl_hash_add(&hash_static, &key3, strlen(key3), &key3);
|
|
fail_unless(nodep, "insertion into hash failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key3, strlen(key3));
|
|
fail_unless(nodep == key3, "hash retrieval failed");
|
|
|
|
/* The fourth element exceeds the number of slots & collides */
|
|
nodep = Curl_hash_add(&hash_static, &key4, strlen(key4), &key4);
|
|
fail_unless(nodep, "insertion into hash failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key4, strlen(key4));
|
|
fail_unless(nodep == key4, "hash retrieval failed");
|
|
|
|
/* Make sure all elements are still accessible */
|
|
nodep = Curl_hash_pick(&hash_static, &key1, strlen(key1));
|
|
fail_unless(nodep == key1, "hash retrieval failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key2, strlen(key2));
|
|
fail_unless(nodep == key2, "hash retrieval failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key3, strlen(key3));
|
|
fail_unless(nodep == key3, "hash retrieval failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key4, strlen(key4));
|
|
fail_unless(nodep == key4, "hash retrieval failed");
|
|
|
|
/* Delete the second of two entries in a bucket */
|
|
rc = Curl_hash_delete(&hash_static, &key4, strlen(key4));
|
|
fail_unless(rc == 0, "hash delete failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key1, strlen(key1));
|
|
fail_unless(nodep == key1, "hash retrieval failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key4, strlen(key4));
|
|
fail_unless(!nodep, "hash retrieval should have failed");
|
|
|
|
/* Insert that deleted node again */
|
|
nodep = Curl_hash_add(&hash_static, &key4, strlen(key4), &key4);
|
|
fail_unless(nodep, "insertion into hash failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key4, strlen(key4));
|
|
fail_unless(nodep == key4, "hash retrieval failed");
|
|
|
|
/* Delete the first of two entries in a bucket */
|
|
rc = Curl_hash_delete(&hash_static, &key1, strlen(key1));
|
|
fail_unless(rc == 0, "hash delete failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key1, strlen(key1));
|
|
fail_unless(!nodep, "hash retrieval should have failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key4, strlen(key4));
|
|
fail_unless(nodep == key4, "hash retrieval failed");
|
|
|
|
/* Delete the remaining one of two entries in a bucket */
|
|
rc = Curl_hash_delete(&hash_static, &key4, strlen(key4));
|
|
fail_unless(rc == 0, "hash delete failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key1, strlen(key1));
|
|
fail_unless(!nodep, "hash retrieval should have failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key4, strlen(key4));
|
|
fail_unless(!nodep, "hash retrieval should have failed");
|
|
|
|
/* Delete an already deleted node */
|
|
rc = Curl_hash_delete(&hash_static, &key4, strlen(key4));
|
|
fail_unless(rc, "hash delete should have failed");
|
|
|
|
/* Replace an existing node */
|
|
nodep = Curl_hash_add(&hash_static, &key1, strlen(key1), ¬akey);
|
|
fail_unless(nodep, "insertion into hash failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key1, strlen(key1));
|
|
fail_unless(nodep == notakey, "hash retrieval failed");
|
|
|
|
/* Make sure all remaining elements are still accessible */
|
|
nodep = Curl_hash_pick(&hash_static, &key2, strlen(key2));
|
|
fail_unless(nodep == key2, "hash retrieval failed");
|
|
nodep = Curl_hash_pick(&hash_static, &key3, strlen(key3));
|
|
fail_unless(nodep == key3, "hash retrieval failed");
|
|
|
|
/* Add element with own destructor */
|
|
nodep = Curl_hash_add2(&hash_static, &key1, strlen(key1), &key1,
|
|
my_elem_dtor);
|
|
fail_unless(nodep, "add2 insertion into hash failed");
|
|
fail_unless(elem_dtor_calls == 0, "element destructor count should be 0");
|
|
/* Add it again, should invoke destructor on first */
|
|
nodep = Curl_hash_add2(&hash_static, &key1, strlen(key1), &key1,
|
|
my_elem_dtor);
|
|
fail_unless(nodep, "add2 again, insertion into hash failed");
|
|
fail_unless(elem_dtor_calls == 1, "element destructor count should be 1");
|
|
/* remove, should invoke destructor */
|
|
rc = Curl_hash_delete(&hash_static, &key1, strlen(key1));
|
|
fail_unless(rc == 0, "hash delete failed");
|
|
fail_unless(elem_dtor_calls == 2, "element destructor count should be 1");
|
|
|
|
/* Clean up */
|
|
Curl_hash_clean(&hash_static);
|
|
|
|
UNITTEST_END(t1603_stop(&hash_static))
|
|
}
|