mirror of
https://github.com/curl/curl.git
synced 2026-04-15 02:31:40 +03:00
ea98445680
Before this patch `ENABLE_DEBUG=ON` always enabled the TrackMemory
(aka `ENABLE_CURLDEBUG=ON`) feature, but required the `Debug` CMake
configration to actually enable curl debug features
(aka `-DDEBUGBUILD`).
Curl debug features do not require compiling with C debug options. This
also made enabling debug features unintuitive and complicated to use.
Due to other issues (subject to PR #13694) it also caused an error in
default (and `Release`/`MinSizeRel`/`RelWithDebInfo`) configs, when
building the `testdeps` target:
```
ld: CMakeFiles/unit1395.dir/unit1395.c.o: in function `test':
unit1395.c:(.text+0x1a0): undefined reference to `dedotdotify'
```
Ref: https://github.com/curl/curl/actions/runs/9037287098/job/24835990826#step:3:2483
Fix it by always defining `DEBUGBUILD` when setting `ENABLE_DEBUG=ON`.
Decoupling this option from the selected CMake configuration.
Note that after this patch `ENABLE_DEBUG=ON` unconditionally enables
curl debug features. These features are insecure and unsuited for
production. Make sure to omit this option when building for production
in default, `Release` (and other not-`Debug`) modes.
Also delete a workaround no longer necessary in GHA CI jobs.
Ref:
|
||
|---|---|---|
| .. | ||
| appveyor-status.yml | ||
| awslc.yml | ||
| badwords.yml | ||
| codeql-analysis.yml | ||
| codespell.yml | ||
| configure-vs-cmake.yml | ||
| curl-for-win.yml | ||
| distcheck.yml | ||
| fuzz.yml | ||
| hacktoberfest-accepted.yml | ||
| label.yml | ||
| linkcheck.yml | ||
| linux-old.yml | ||
| linux.yml | ||
| linux32.yml | ||
| macos.yml | ||
| man-examples.yml | ||
| ngtcp2-linux.yml | ||
| non-native.yml | ||
| osslq-linux.yml | ||
| proselint.yml | ||
| quiche-linux.yml | ||
| reuse.yml | ||
| shellcheck.yml | ||
| spellcheck.yml | ||
| synopsis.yml | ||
| torture.yml | ||
| windows.yml | ||
| wolfssl.yml | ||