curl/lib/vssh
Joel Depooter e3d9675924
libssh: fix incorrect return value in myssh_in_AUTH_PKEY_INIT
In the unlikely case that no SSH auth methods are supported, the
previous code would return 0 from myssh_in_AUTH_PKEY_INIT. However,
following the code path, it seems like it should be returning SSH_ERROR,
as set in myssh_to_ERROR (through myssh_to_GSSAPI_AUTH,
myssh_to_KEY_AUTH and myssh_to_PASSWD_AUTH).

In actuality, this is unlikely to occur, as the similar code in
myssh_in_AUTHLIST would have already returned an error in this scenario.
However setting a return value and then ignoring it is a bit fishy and
should be documented if this is intended.

I believe this used to return an error, but was changed in the recent
re-factoring of this code.

Closes #17691
2025-06-21 10:51:11 +02:00
..
.checksrc checksrc: use 'banfunc' proper in more places 2025-01-13 09:10:58 +01:00
curl_path.c curl_path: make SFTP handle a path like /~ properly. 2025-06-09 11:23:16 +02:00
curl_path.h lib: include files using known path 2025-04-08 17:00:00 +02:00
libssh.c libssh: fix incorrect return value in myssh_in_AUTH_PKEY_INIT 2025-06-21 10:51:11 +02:00
libssh2.c lib: unify recv/send function signatures 2025-06-11 11:21:10 +02:00
ssh.h libssh2: remove the 'actualcode' struct field 2025-05-16 14:56:59 +02:00
wolfssh.c lib: unify recv/send function signatures 2025-06-11 11:21:10 +02:00