curl/tests/unit
Viktor Szakats e088e10454
cmake: replace the way clang-tidy verifies tests, fix issues found
Replace existing `mk-unity.pl` `--embed` workaround with running
`clang-tidy` manually on individual test source instead. This aligns
with how clang-tidy works and removes `mk-unity.pl` from the solution.

Also:
- mqttd: fix potentially uninitialized buffer by zero filling it.
  ```
  tests/server/mqttd.c:484:41: error: The left operand of '<<' is a garbage value
    [clang-analyzer-core.UndefinedBinaryOperatorResult,-warnings-as-errors]
    484 |       payload_len = (size_t)(buffer[10] << 8) | buffer[11];
        |                                         ^
  [...]
  tests/server/mqttd.c:606:45: error: The left operand of '<<' is a garbage value
    [clang-analyzer-core.UndefinedBinaryOperatorResult,-warnings-as-errors]
    606 |       topiclen = (size_t)(buffer[1 + bytes] << 8) | buffer[2 + bytes];
        |                                             ^
  ```
- sockfilt: fix potential out-of-bound pointer:
  ```
  tests/server/sockfilt.c:1128:33: error: The 2nd argument to 'send' is a buffer
     with size 17010 but should be a buffer with size equal to or greater than
     the value of the 3rd argument (which is 18446744073709551615)
     [clang-analyzer-unix.StdCLibraryFunctions,-warnings-as-errors]
   1128 |         ssize_t bytes_written = swrite(sockfd, buffer, buffer_len);
        |                                 ^
  ```
- clang-tidy: suppress bogus `bzero()` warnings that happens
  inside the notorious `FD_ZERO()` macros, on macOS.

Ref: https://github.com/curl/curl/pull/17680#issuecomment-2991730158

Closes #17705
2025-06-22 23:08:46 +02:00
..
.gitignore tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
CMakeLists.txt cmake: replace the way clang-tidy verifies tests, fix issues found 2025-06-22 23:08:46 +02:00
curlcheck.h tests: tidy up server main function, whitespace and README 2025-06-15 14:11:21 +02:00
Makefile.am tests: drop BUNDLE_SRC variable 2025-06-21 10:49:05 +02:00
Makefile.inc tests: drop BUNDLE_SRC variable 2025-06-21 10:49:05 +02:00
README.md tests: tidy up server main function, whitespace and README 2025-06-15 14:11:21 +02:00
unit1300.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1302.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1303.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1304.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1305.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1307.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1309.c warnless: drop parts of the read/write preprocessor hack (Windows) 2025-06-19 17:09:43 +02:00
unit1323.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1330.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1395.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1396.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1397.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1398.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1399.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1600.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1601.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1602.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1603.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1605.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1606.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1607.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1608.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1609.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1610.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1611.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1612.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1614.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1615.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1616.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1620.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1650.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1651.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1652.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1653.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1654.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1655.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1656.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1657.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1658.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1660.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1661.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1663.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1664.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1979.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit1980.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit2600.c cf: replace the method get_host with query 2025-06-21 17:20:44 +02:00
unit2601.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit2602.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit2603.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit2604.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit3200.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit3205.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit3211.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit3212.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00
unit3213.c tests: always make bundles, adapt build and tests 2025-06-14 21:08:23 +02:00

Unit tests

The goal is to add tests for all functions in libcurl. If functions are too big and complicated, we should split them into smaller and testable ones.

Build Unit Tests

./configure --enable-debug is required for the unit tests to build. To enable unit tests, there is a separate static libcurl built that is used exclusively for linking unit test programs. Just build everything as normal, and then you can run the unit test cases as well.

Run Unit Tests

Unit tests are run as part of the regular test suite. If you have built everything to run unit tests, to can do 'make test' at the root level. Or you can cd tests and make and then invoke individual unit tests with ./runtests.pl NNNN where NNNN is the specific test number.

Debug Unit Tests

If a specific test fails you get told. The test case then has output left in the %LOGDIR subdirectory, but most importantly you can re-run the test again using gdb by doing ./runtests.pl -g NNNN. That is, add a -g to make it start up gdb and run the same case using that.

Write Unit Tests

We put tests that focus on an area or a specific function into a single C source file. The source file should be named unitNNNN.c where NNNN is a previously unused number.

Add your test to tests/unit/Makefile.inc (if it is a unit test). Add your test data filename to tests/data/Makefile.am

You also need a separate file called tests/data/testNNNN (using the same number) that describes your test case. See the test1300 file for inspiration and the tests/FILEFORMAT.md documentation.

For the actual C file, here's a simple example:

    #include "curlcheck.h"

    #include "a libcurl header.h" /* from the lib dir */

    static CURLcode test_unit9998(char *arg)
    {
      UNITTEST_BEGIN_SIMPLE

      /* here you start doing things and checking that the results are good */

      fail_unless( size == 0 , "initial size should be zero" );
      fail_if( head == NULL , "head should not be initiated to NULL" );

      /* you end the test code like this: */

      UNITTEST_END_SIMPLE
    }

Here's an example using optional initialization and cleanup:

    #include "curlcheck.h"

    #include "a libcurl header.h" /* from the lib dir */

    static CURLcode t9999_setup(void)
    {
      /* whatever you want done first */
      return CURLE_OK;
    }

    static void t9999_stop(void)
    {
      /* done before shutting down and exiting */
    }

    static CURLcode test_unit9999(char *arg)
    {
      UNITTEST_BEGIN(t9999_setup())

      /* here you start doing things and checking that the results are good */

      fail_unless( size == 0 , "initial size should be zero" );
      fail_if( head == NULL , "head should not be initiated to NULL" );

      /* you end the test code like this: */

      UNITTEST_END(t9999_stop())
    }