mirror of
https://github.com/curl/curl.git
synced 2026-05-02 11:57:53 +03:00
By passing to clang-tidy the C compiler with `--target` and sysroot
options, if any.
Fixing (GHA/windows, linux-mingw, CM clang-tidy):
```
lib/curl_setup.h:841:10: error: 'io.h' file not found [clang-diagnostic-error]
841 | #include <io.h>
| ^~~~~~
Found compiler error(s).
FAILED: [code=1] tests/server/CMakeFiles/servers-clang-tidy bld/tests/server/CMakeFiles/servers-clang-tidy
cd tests/server && /usr/bin/clang-tidy --config-file=.clang-tidy.yml
--warnings-as-errors=* --checks=-clang-diagnostic-unused-function first.c getpart.c util.c dnsd.c [...]
-- <-D-options> <-I-options> <cflags>
```
For reference, this is CMake's built-in clang-tidy invocation:
```
/usr/local/bin/cmake -E __run_co_compile --tidy="/usr/bin/clang-tidy;--config-file=.clang-tidy.yml;
--warnings-as-errors=*;--extra-arg-before=--driver-mode=gcc" --source=lib/curl_fopen.c
-- /usr/bin/clang --target=x86_64-w64-mingw32 <-D-options> <-I-options> <cflags>
```
Also:
- bump cmakelint `--max-statements`. Needs 59 after this patch.
- use undocumented CMake variables:
- `CMAKE_C_COMPILE_OPTIONS_TARGET` for `--target=`
- `CMAKE_C_COMPILE_OPTIONS_SYSROOT` for `--sysroot=`
Cherry-picked from #20631
Closes #20640
215 lines
7.7 KiB
CMake
215 lines
7.7 KiB
CMake
#***************************************************************************
|
|
# _ _ ____ _
|
|
# Project ___| | | | _ \| |
|
|
# / __| | | | |_) | |
|
|
# | (__| |_| | _ <| |___
|
|
# \___|\___/|_| \_\_____|
|
|
#
|
|
# Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
#
|
|
# This software is licensed as described in the file COPYING, which
|
|
# you should have received as part of this distribution. The terms
|
|
# are also available at https://curl.se/docs/copyright.html.
|
|
#
|
|
# You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
# copies of the Software, and permit persons to whom the Software is
|
|
# furnished to do so, under the terms of the COPYING file.
|
|
#
|
|
# This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
# KIND, either express or implied.
|
|
#
|
|
# SPDX-License-Identifier: curl
|
|
#
|
|
###########################################################################
|
|
# File defines convenience macros for available feature testing
|
|
|
|
# Check if header file exists and add it to the list.
|
|
# This macro is intended to be called multiple times with a sequence of
|
|
# possibly dependent header files. Some headers depend on others to be
|
|
# compiled correctly.
|
|
macro(check_include_file_concat_curl _file _variable)
|
|
check_include_files("${CURL_INCLUDES};${_file}" ${_variable})
|
|
if(${_variable})
|
|
list(APPEND CURL_INCLUDES ${_file})
|
|
endif()
|
|
endmacro()
|
|
|
|
set(CURL_TEST_DEFINES "") # Initialize global variable
|
|
|
|
# For other curl specific tests, use this macro.
|
|
# Return result in variable: CURL_TEST_OUTPUT
|
|
macro(curl_internal_test _curl_test)
|
|
if(NOT DEFINED "${_curl_test}")
|
|
string(REPLACE ";" " " _cmake_required_definitions "${CMAKE_REQUIRED_DEFINITIONS}")
|
|
set(_curl_test_add_libraries "")
|
|
if(CMAKE_REQUIRED_LIBRARIES)
|
|
set(_curl_test_add_libraries
|
|
"-DLINK_LIBRARIES:STRING=${CMAKE_REQUIRED_LIBRARIES}")
|
|
endif()
|
|
|
|
message(STATUS "Performing Test ${_curl_test}")
|
|
try_compile(${_curl_test}
|
|
${PROJECT_BINARY_DIR}
|
|
"${CMAKE_CURRENT_SOURCE_DIR}/CMake/CurlTests.c"
|
|
CMAKE_FLAGS
|
|
"-DCOMPILE_DEFINITIONS:STRING=-D${_curl_test} ${CURL_TEST_DEFINES} ${CMAKE_REQUIRED_FLAGS} ${_cmake_required_definitions}"
|
|
"${_curl_test_add_libraries}"
|
|
OUTPUT_VARIABLE CURL_TEST_OUTPUT)
|
|
if(${_curl_test})
|
|
set(${_curl_test} 1 CACHE INTERNAL "curl test")
|
|
message(STATUS "Performing Test ${_curl_test} - Success")
|
|
else()
|
|
set(${_curl_test} "" CACHE INTERNAL "curl test")
|
|
message(STATUS "Performing Test ${_curl_test} - Failed")
|
|
endif()
|
|
endif()
|
|
endmacro()
|
|
|
|
# Option for dependencies that accepts an 'AUTO' value, which enables the dependency if detected.
|
|
macro(curl_dependency_option _option_name _find_name _desc_name)
|
|
set(${_option_name} "AUTO" CACHE STRING "Build curl with ${_desc_name} support (AUTO, ON or OFF)")
|
|
set_property(CACHE ${_option_name} PROPERTY STRINGS "AUTO" "ON" "OFF")
|
|
|
|
if(${_option_name} STREQUAL "AUTO")
|
|
find_package(${_find_name})
|
|
elseif(${_option_name})
|
|
find_package(${_find_name} REQUIRED)
|
|
else()
|
|
string(TOUPPER "${_find_name}" _find_name_upper)
|
|
set(${_find_name}_FOUND OFF) # cmake-lint: disable=C0103
|
|
set(${_find_name_upper}_FOUND OFF) # cmake-lint: disable=C0103
|
|
endif()
|
|
endmacro()
|
|
|
|
# Convert the passed paths to libpath linker options and add them to CMAKE_REQUIRED_*.
|
|
macro(curl_required_libpaths _libpaths_arg)
|
|
if(CMAKE_VERSION VERSION_LESS 3.31)
|
|
set(_libpaths "${_libpaths_arg}")
|
|
foreach(_libpath IN LISTS _libpaths)
|
|
list(APPEND CMAKE_REQUIRED_LINK_OPTIONS "${CMAKE_LIBRARY_PATH_FLAG}${_libpath}")
|
|
endforeach()
|
|
else()
|
|
list(APPEND CMAKE_REQUIRED_LINK_DIRECTORIES "${_libpaths_arg}")
|
|
endif()
|
|
endmacro()
|
|
|
|
# Pre-fill variables set by a check_type_size() call.
|
|
macro(curl_prefill_type_size _type _size)
|
|
set(HAVE_SIZEOF_${_type} TRUE)
|
|
set(SIZEOF_${_type} ${_size})
|
|
set(SIZEOF_${_type}_CODE "#define SIZEOF_${_type} ${_size}")
|
|
endmacro()
|
|
|
|
# Internal: Recurse into target libraries and collect their include directories
|
|
# and macro definitions.
|
|
macro(curl_collect_target_options _target)
|
|
get_target_property(_val ${_target} COMPILE_DEFINITIONS)
|
|
if(_val)
|
|
list(APPEND _definitions ${_val})
|
|
endif()
|
|
get_target_property(_val ${_target} INTERFACE_INCLUDE_DIRECTORIES)
|
|
if(_val)
|
|
list(APPEND _includes ${_val})
|
|
endif()
|
|
get_target_property(_val ${_target} INCLUDE_DIRECTORIES)
|
|
if(_val)
|
|
list(APPEND _includes ${_val})
|
|
endif()
|
|
get_target_property(_val ${_target} COMPILE_OPTIONS)
|
|
if(_val)
|
|
list(APPEND _options ${_val})
|
|
endif()
|
|
get_target_property(_val ${_target} LINK_LIBRARIES)
|
|
if(_val)
|
|
foreach(_lib IN LISTS _val)
|
|
if(TARGET "${_lib}")
|
|
curl_collect_target_options(${_lib})
|
|
endif()
|
|
endforeach()
|
|
endif()
|
|
unset(_val)
|
|
endmacro()
|
|
|
|
# Create a clang-tidy target for test targets
|
|
macro(curl_add_clang_tidy_test_target _target_clang_tidy _target)
|
|
if(CURL_CLANG_TIDY)
|
|
|
|
set(_definitions "")
|
|
set(_includes "")
|
|
set(_options "")
|
|
|
|
# Collect macro definitions and header directories applying to the directory
|
|
get_directory_property(_val COMPILE_DEFINITIONS)
|
|
if(_val)
|
|
list(APPEND _definitions ${_val})
|
|
endif()
|
|
get_directory_property(_val INCLUDE_DIRECTORIES)
|
|
if(_val)
|
|
list(APPEND _includes ${_val})
|
|
endif()
|
|
get_directory_property(_val COMPILE_OPTIONS)
|
|
if(_val)
|
|
list(APPEND _options ${_val})
|
|
endif()
|
|
unset(_val)
|
|
|
|
# Collect header directories and macro definitions from lib dependencies
|
|
curl_collect_target_options(${_target})
|
|
|
|
list(REMOVE_ITEM _definitions "")
|
|
string(REPLACE ";" ";-D" _definitions ";${_definitions}")
|
|
list(REMOVE_DUPLICATES _definitions)
|
|
list(SORT _definitions) # Sort like CMake does
|
|
|
|
set(_includes_tmp ${_includes})
|
|
set(_includes)
|
|
foreach(_inc IN LISTS _includes_tmp)
|
|
# Avoid empty and '$<INSTALL_INTERFACE:include>' items. The latter also
|
|
# evaluates to an empty path in this context.
|
|
if(_inc AND NOT _inc MATCHES "INSTALL_INTERFACE:")
|
|
list(APPEND _includes "-I${_inc}")
|
|
endif()
|
|
endforeach()
|
|
list(REMOVE_DUPLICATES _includes)
|
|
|
|
if(CMAKE_C_COMPILER_ID MATCHES "Clang")
|
|
list(REMOVE_DUPLICATES _options) # Keep the first of duplicates to imitate CMake
|
|
else()
|
|
set(_options)
|
|
endif()
|
|
|
|
# Assemble source list
|
|
set(_sources "")
|
|
foreach(_source IN ITEMS ${ARGN})
|
|
if(NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/${_source}") # if not in source tree
|
|
set(_source "${CMAKE_CURRENT_BINARY_DIR}/${_source}") # look in the build tree, for generated files, e.g. lib1521.c
|
|
endif()
|
|
list(APPEND _sources "${_source}")
|
|
endforeach()
|
|
|
|
set(_cc "${CMAKE_C_COMPILER}")
|
|
if(CMAKE_C_COMPILER_TARGET AND CMAKE_C_COMPILE_OPTIONS_TARGET)
|
|
list(APPEND _cc "${CMAKE_C_COMPILE_OPTIONS_TARGET}${CMAKE_C_COMPILER_TARGET}")
|
|
endif()
|
|
if(APPLE AND CMAKE_OSX_SYSROOT)
|
|
list(APPEND _cc "-isysroot" "${CMAKE_OSX_SYSROOT}")
|
|
elseif(CMAKE_SYSROOT AND CMAKE_C_COMPILE_OPTIONS_SYSROOT)
|
|
list(APPEND _cc "${CMAKE_C_COMPILE_OPTIONS_SYSROOT}${CMAKE_SYSROOT}")
|
|
endif()
|
|
|
|
# Pass -clang-diagnostic-unused-function to disable -Wunused-function implied by -Wunused
|
|
add_custom_target(${_target_clang_tidy} USES_TERMINAL
|
|
WORKING_DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}"
|
|
COMMAND ${CMAKE_C_CLANG_TIDY}
|
|
"--checks=-clang-diagnostic-unused-function"
|
|
${_sources} -- ${_cc} ${_definitions} ${_includes} ${_options}
|
|
DEPENDS ${_sources})
|
|
add_dependencies(tests-clang-tidy ${_target_clang_tidy})
|
|
|
|
unset(_cc)
|
|
unset(_definitions)
|
|
unset(_includes)
|
|
unset(_options)
|
|
unset(_sources)
|
|
endif()
|
|
endmacro()
|