mirror of
https://github.com/curl/curl.git
synced 2026-04-27 01:32:11 +03:00
9465327084
- cmake: disable test bundles for clang-tidy builds. clang-tidy ignores #included .c sources, and incompatible with unity and bundles. It caused clang-tidy ignoring all test sources. It also means this is the first time tests sources are checked with clang-tidy. (autotools doesn't run it on tests.) - cmake: update description for `CURL_TEST_BUNDLES` option. - fix tests using special `CURLE_*` enums that were missing from `curl/curl.h`. Add them as reserved codes. - fix about ~50 other issues detected by clang-tidy: unchecked results, NULL derefs, memory leaks, casts to enums, unused assigments, uninitialized `errno` uses, unchecked `open`, indent, and more. - drop unnecessary casts (lib1533, lib3207). - suppress a few impossible cases with detailed `NOLINT`s. - lib/escape.c: drop `NOLINT` no longer necessary. Follow-up to72abf7c13a#13862 (possibly) - extend two existing `NOLINT` comments with details. Follow-up tofabfa8e402#15825 Closes #16756
139 lines
5 KiB
C
139 lines
5 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "curlcheck.h"
|
|
|
|
#include "urldata.h"
|
|
#include "altsvc.h"
|
|
|
|
static CURLcode
|
|
unit_setup(void)
|
|
{
|
|
return CURLE_OK;
|
|
}
|
|
|
|
static void
|
|
unit_stop(void)
|
|
{
|
|
curl_global_cleanup();
|
|
}
|
|
|
|
UNITTEST_START
|
|
#if !defined(CURL_DISABLE_HTTP) && !defined(CURL_DISABLE_ALTSVC)
|
|
{
|
|
char outname[256];
|
|
CURL *curl;
|
|
CURLcode result;
|
|
struct altsvcinfo *asi = Curl_altsvc_init();
|
|
abort_if(!asi, "Curl_altsvc_i");
|
|
result = Curl_altsvc_load(asi, arg);
|
|
if(result) {
|
|
fail_if(result, "Curl_altsvc_load");
|
|
goto fail;
|
|
}
|
|
curl_global_init(CURL_GLOBAL_ALL);
|
|
curl = curl_easy_init();
|
|
if(!curl) {
|
|
fail_if(!curl, "curl_easy_init");
|
|
goto fail;
|
|
}
|
|
fail_unless(Curl_llist_count(&asi->list) == 4, "wrong number of entries");
|
|
msnprintf(outname, sizeof(outname), "%s-out", arg);
|
|
|
|
result = Curl_altsvc_parse(curl, asi, "h2=\"example.com:8080\"\r\n",
|
|
ALPN_h1, "example.org", 8080);
|
|
fail_if(result, "Curl_altsvc_parse() failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 5, "wrong number of entries");
|
|
|
|
result = Curl_altsvc_parse(curl, asi, "h3=\":8080\"\r\n",
|
|
ALPN_h1, "2.example.org", 8080);
|
|
fail_if(result, "Curl_altsvc_parse(2) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 6, "wrong number of entries");
|
|
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.com:8080\", "
|
|
"h3=\"yesyes.com:8080\"\r\n",
|
|
ALPN_h1, "3.example.org", 8080);
|
|
fail_if(result, "Curl_altsvc_parse(3) failed!");
|
|
/* that one should make two entries */
|
|
fail_unless(Curl_llist_count(&asi->list) == 8, "wrong number of entries");
|
|
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.com:443\"; ma = 120;\r\n",
|
|
ALPN_h2, "example.org", 80);
|
|
fail_if(result, "Curl_altsvc_parse(4) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 9, "wrong number of entries");
|
|
|
|
/* quoted 'ma' value */
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.net:443\"; ma=\"180\";\r\n",
|
|
ALPN_h2, "example.net", 80);
|
|
fail_if(result, "Curl_altsvc_parse(5) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 10, "wrong number of entries");
|
|
|
|
result =
|
|
Curl_altsvc_parse(curl, asi,
|
|
"h2=\":443\", h3=\":443\"; "
|
|
"persist = \"1\"; ma = 120;\r\n",
|
|
ALPN_h1, "curl.se", 80);
|
|
fail_if(result, "Curl_altsvc_parse(6) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 12, "wrong number of entries");
|
|
|
|
/* clear that one again and decrease the counter */
|
|
result = Curl_altsvc_parse(curl, asi, "clear;\r\n",
|
|
ALPN_h1, "curl.se", 80);
|
|
fail_if(result, "Curl_altsvc_parse(7) failed!");
|
|
fail_unless(Curl_llist_count(&asi->list) == 10, "wrong number of entries");
|
|
|
|
/* only a non-existing alpn */
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h6=\"example.net:443\"; ma=\"180\";\r\n",
|
|
ALPN_h2, "5.example.net", 80);
|
|
fail_if(result, "Curl_altsvc_parse(8) failed!");
|
|
|
|
/* missing quote in alpn host */
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.net:443,; ma=\"180\";\r\n",
|
|
ALPN_h2, "6.example.net", 80);
|
|
fail_if(result, "Curl_altsvc_parse(9) failed!");
|
|
|
|
/* missing port in host name */
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.net\"; ma=\"180\";\r\n",
|
|
ALPN_h2, "7.example.net", 80);
|
|
fail_if(result, "Curl_altsvc_parse(10) failed!");
|
|
|
|
/* illegal port in host name */
|
|
result = Curl_altsvc_parse(curl, asi,
|
|
"h2=\"example.net:70000\"; ma=\"180\";\r\n",
|
|
ALPN_h2, "8.example.net", 80);
|
|
fail_if(result, "Curl_altsvc_parse(11) failed!");
|
|
|
|
Curl_altsvc_save(curl, asi, outname);
|
|
|
|
curl_easy_cleanup(curl);
|
|
fail:
|
|
Curl_altsvc_cleanup(&asi);
|
|
}
|
|
#endif
|
|
UNITTEST_STOP
|