romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-04-15 13:11:41 +03:00
Code Issues Projects Releases Packages Wiki Activity
curl/.github/workflows
History
Viktor Szakats bf9d9fe0bd
multissl: initialize when requesting a random number 
To fix test 1308 in MultiSSL builds.

Failure was caused by the random number generator virtual function being
NULL, instead of pointing to the implementation in the runtime-selected
TLS backend. This could happen in MultiSSL builds when a functionality
was asking for a random number without triggering a VTLS function table
initialization first. Such functionality is MIME, or form data via MIME.

The reason CI did not catch it in an earlier MultiSSL GHA/windows job,
is that it was a debug-enabled one. In debug-enabled builds the test
runner was overriding the random number generator for all tests.

Fixed this by moving the override to the tests requiring it, via
1fcf22585f #17971, enabling debug builds
to catch this issue.

Enable MultiSSL in two CI jobs, to verify this patch.

Fixing:
```
test 1308...[formpost tests]

libtests returned 44, when expecting 0
 1308: exit FAILED
[...]
=== Start of file stderr1308
 URL: log/3/test-1308
 tests/libtest/lib1308.c:70 Assertion 'res == 0' FAILED: curl_formget returned error
 tests/libtest/lib1308.c:72 Assertion 'total_size == 518' FAILED: curl_formget got wrong size back
 tests/libtest/lib1308.c:88 Assertion 'res == 0' FAILED: curl_formget returned error
 tests/libtest/lib1308.c:89 Assertion 'total_size == 899' FAILED: curl_formget got wrong size back
```
Ref: https://github.com/curl/curl/actions/runs/16387693424/job/46309536359?pr=17963#step:16:2515

Bug: https://github.com/curl/curl/pull/17963#issuecomment-3092282057

Closes #17970
2025-07-20 12:03:56 +02:00
..
appveyor-status.yml GHA: fix zizmor 1.10.0 warnings, update names 2025-06-30 18:38:56 +02:00
checkdocs.yml GHA: fix zizmor 1.10.0 warnings, update names 2025-06-30 18:38:56 +02:00
checksrc.yml GHA: minor tidy-ups 2025-07-13 11:52:08 +02:00
configure-vs-cmake.yml GHA: fix zizmor 1.10.0 warnings, update names 2025-06-30 18:38:56 +02:00
curl-for-win.yml GHA/curl-for-win: reduce job timeout to 10m, apply to Windows jobs 2025-07-07 19:03:00 +02:00
distcheck.yml checksrc-all: rewrite in Perl, remove checksrc.bat 2025-07-11 12:28:46 +02:00
fuzz.yml CI: skip CI builds that just touch Dockerfile 2025-07-02 18:28:24 -07:00
hacktoberfest-accepted.yml GHA: fix zizmor 1.10.0 warnings, update names 2025-06-30 18:38:56 +02:00
http3-linux.yml GHA: update dependency wolfSSL/wolfssl to v5.8.2 2025-07-18 00:54:34 +02:00
label.yml GHA: fix zizmor 1.10.0 warnings, update names 2025-06-30 18:38:56 +02:00
linux-old.yml CI: skip CI builds that just touch Dockerfile 2025-07-02 18:28:24 -07:00
linux.yml multissl: initialize when requesting a random number 2025-07-20 12:03:56 +02:00
macos.yml multissl: initialize when requesting a random number 2025-07-20 12:03:56 +02:00
non-native.yml GHA: move iOS jobs from non-native to macos workflow 2025-07-14 14:01:46 +02:00
windows.yml GHA/windows: drop Windows CE jobs from CI 2025-07-14 14:01:46 +02:00