mirror of
https://github.com/curl/curl.git
synced 2026-04-21 10:52:13 +03:00
The issues found fell into these categories, with the applied fixes:
- const was accidentally stripped.
Adjust code to not cast or cast with const.
- const/volatile missing from arguments, local variables.
Constify arguments or variables, adjust/delete casts. Small code
changes in a few places.
- const must be stripped because an API dependency requires it.
Strip `const` with `CURL_UNCONST()` macro to silence the warning out
of our control. These happen at API boundaries. Sometimes they depend
on dependency version, which this patch handles as necessary. Also
enable const support for the zlib API, using `ZLIB_CONST`. Supported
by zlib 1.2.5.2 and newer.
- const must be stripped because a curl API requires it.
Strip `const` with `CURL_UNCONST()` macro to silence the warning out
of our immediate control. For example we promise to send a non-const
argument to a callback, though the data is const internally.
- other cases where we may avoid const stripping by code changes.
Also silenced with `CURL_UNCONST()`.
- there are 3 places where `CURL_UNCONST()` is cast again to const.
To silence this type of warning:
```
lib/vquic/curl_osslq.c:1015:29: error: to be safe all intermediate
pointers in cast from 'unsigned char **' to 'const unsigned char **'
must be 'const' qualified [-Werror=cast-qual]
lib/cf-socket.c:734:32: error: to be safe all intermediate pointers in
cast from 'char **' to 'const char **' must be 'const' qualified
[-Werror=cast-qual]
```
There may be a better solution, but I couldn't find it.
These cases are handled in separate subcommits, but without further
markup.
If you see a `-Wcast-qual` warning in curl, we appreciate your report
about it.
Closes #16142
151 lines
3.6 KiB
C
151 lines
3.6 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "server_setup.h"
|
|
|
|
/* Purpose
|
|
*
|
|
* Resolve the given name, using system name resolve functions (NOT any
|
|
* function provided by libcurl). Used to see if the name exists and thus if
|
|
* we can allow a test case to use it for testing.
|
|
*
|
|
* Like if 'localhost' actual exists etc.
|
|
*
|
|
*/
|
|
|
|
#ifdef HAVE_NETINET_IN_H
|
|
#include <netinet/in.h>
|
|
#endif
|
|
#ifdef _XOPEN_SOURCE_EXTENDED
|
|
/* This define is "almost" required to build on HP-UX 11 */
|
|
#include <arpa/inet.h>
|
|
#endif
|
|
#ifdef HAVE_NETDB_H
|
|
#include <netdb.h>
|
|
#endif
|
|
|
|
#include "curlx.h" /* from the private lib dir */
|
|
#include "util.h"
|
|
|
|
/* include memdebug.h last */
|
|
#include "memdebug.h"
|
|
|
|
int main(int argc, char *argv[])
|
|
{
|
|
int arg = 1;
|
|
const char *host = NULL;
|
|
int rc = 0;
|
|
|
|
while(argc > arg) {
|
|
if(!strcmp("--version", argv[arg])) {
|
|
printf("resolve IPv4%s\n",
|
|
#if defined(CURLRES_IPV6)
|
|
"/IPv6"
|
|
#else
|
|
""
|
|
#endif
|
|
);
|
|
return 0;
|
|
}
|
|
else if(!strcmp("--ipv6", argv[arg])) {
|
|
#if defined(CURLRES_IPV6)
|
|
ipv_inuse = "IPv6";
|
|
use_ipv6 = TRUE;
|
|
arg++;
|
|
#else
|
|
puts("IPv6 support has been disabled in this program");
|
|
return 1;
|
|
#endif
|
|
}
|
|
else if(!strcmp("--ipv4", argv[arg])) {
|
|
/* for completeness, we support this option as well */
|
|
ipv_inuse = "IPv4";
|
|
#if defined(CURLRES_IPV6)
|
|
use_ipv6 = FALSE;
|
|
#endif
|
|
arg++;
|
|
}
|
|
else {
|
|
host = argv[arg++];
|
|
}
|
|
}
|
|
if(!host) {
|
|
puts("Usage: resolve [option] <host>\n"
|
|
" --version\n"
|
|
" --ipv4"
|
|
#if defined(CURLRES_IPV6)
|
|
"\n --ipv6"
|
|
#endif
|
|
);
|
|
return 1;
|
|
}
|
|
|
|
#ifdef _WIN32
|
|
if(win32_init())
|
|
return 2;
|
|
#endif
|
|
|
|
#if defined(CURLRES_IPV6)
|
|
if(use_ipv6) {
|
|
/* Check that the system has IPv6 enabled before checking the resolver */
|
|
curl_socket_t s = socket(PF_INET6, SOCK_DGRAM, 0);
|
|
if(s == CURL_SOCKET_BAD)
|
|
/* an IPv6 address was requested and we can't get/use one */
|
|
rc = -1;
|
|
else {
|
|
sclose(s);
|
|
}
|
|
}
|
|
|
|
if(rc == 0) {
|
|
/* getaddrinfo() resolve */
|
|
struct addrinfo *ai;
|
|
struct addrinfo hints;
|
|
|
|
memset(&hints, 0, sizeof(hints));
|
|
hints.ai_family = use_ipv6 ? PF_INET6 : PF_INET;
|
|
hints.ai_socktype = SOCK_STREAM;
|
|
hints.ai_flags = 0;
|
|
rc = getaddrinfo(host, "80", &hints, &ai);
|
|
if(rc == 0)
|
|
freeaddrinfo(ai);
|
|
}
|
|
#else
|
|
{
|
|
struct hostent *he; /* gethostbyname() resolve */
|
|
|
|
#ifdef __AMIGA__
|
|
he = gethostbyname((unsigned char *)CURL_UNCONST(host));
|
|
#else
|
|
he = gethostbyname(host);
|
|
#endif
|
|
|
|
rc = !he;
|
|
}
|
|
#endif
|
|
|
|
if(rc)
|
|
printf("Resolving %s '%s' didn't work\n", ipv_inuse, host);
|
|
|
|
return !!rc;
|
|
}
|