mirror of
https://github.com/curl/curl.git
synced 2026-04-15 00:41:41 +03:00
9463769f2e
Change the format of error messages sent to stderr from tests and test
servers. As a workaround to avoid triggering Visual Studio's MSBuild
tool's built-in regexp matcher, and making it mark builds failed for
reasons we don't want them to hard fail.
Roughly, the pattern to avoid is the word "error" (case-insensitive)
in the same line with a colon `:`.
It affected GHA/windows MSVC CI jobs, causing flakiness:
```
CUSTOMBUILD : fopen() failed with error : 13 Permission denied [D:\a\curl\curl\bld\tests\test-ci.vcxproj]
Error opening file: log/4/smtp_sockfilt.log
[...]
CUSTOMBUILD : fopen() failed with error : 13 Permission denied [D:\a\curl\curl\bld\tests\test-ci.vcxproj]
Error opening file: log/8/imap_sockfilt.log
Msg not logged: 00:18:10.656000 > 178 bytes data, server => client
[...]
TESTDONE: 1629 tests out of 1634 reported OK: 99%
Building Custom Rule D:/a/curl/curl/tests/CMakeLists.txt
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for 'D:\a\curl\curl\bld\CMakeFiles\621f80ddbb0fa48179f056ca77842ff0\test-ci.rule;D:\a\curl\curl\tests\CMakeLists.txt' exited with code -1. [D:\a\curl\curl\bld\tests\test-ci.vcxproj]
Error: Process completed with exit code 1.
```
Ref: https://github.com/curl/curl/actions/runs/13643149623/job/38137076210?pr=16490#step:14:3125
Ref: https://github.com/curl/curl/actions/runs/13688765792/job/38277961720?pr=16582#step:14:1717
The `IgnoreStandardErrorWarningFormat="true"` MSBuild Exec option
controls this behavior:
https://learn.microsoft.com/visualstudio/msbuild/exec-task#parameters
I couldn't figure out a way to apply it to CMake builds.
MSBuid pattern matching rules:
353c0f3d37/src/Shared/CanonicalError.cs
https://learn.microsoft.com/visualstudio/msbuild/msbuild-diagnostic-format-for-tasks
Note: There may be further error messages output from runtests scripts,
that use this format, which are not explicitly fatal. They may need
future fixes.
Thanks-to: Dion Williams
Ref: https://github.com/curl/curl/discussions/14854#discussioncomment-12382190
Ref: https://github.com/curl/curl/discussions/14854#discussioncomment-12395224
Closes #16583
123 lines
3.2 KiB
C
123 lines
3.2 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "test.h"
|
|
|
|
#ifdef HAVE_FCNTL_H
|
|
#include <fcntl.h>
|
|
#endif
|
|
|
|
#include "memdebug.h"
|
|
|
|
/*
|
|
* Two FTP uploads, the second with no content sent.
|
|
*/
|
|
|
|
CURLcode test(char *URL)
|
|
{
|
|
CURL *curl;
|
|
CURLcode res = CURLE_OK;
|
|
FILE *hd_src;
|
|
int hd;
|
|
struct_stat file_info;
|
|
|
|
if(!libtest_arg2) {
|
|
fprintf(stderr, "Usage: <url> <file-to-upload>\n");
|
|
return TEST_ERR_USAGE;
|
|
}
|
|
|
|
hd_src = fopen(libtest_arg2, "rb");
|
|
if(!hd_src) {
|
|
fprintf(stderr, "fopen failed with error (%d) %s\n",
|
|
errno, strerror(errno));
|
|
fprintf(stderr, "Error opening file '%s'\n", libtest_arg2);
|
|
return (CURLcode)-2; /* if this happens things are major weird */
|
|
}
|
|
|
|
/* get the file size of the local file */
|
|
#ifdef UNDER_CE
|
|
hd = stat(libtest_arg2, &file_info);
|
|
#else
|
|
hd = fstat(fileno(hd_src), &file_info);
|
|
#endif
|
|
if(hd == -1) {
|
|
/* can't open file, bail out */
|
|
fprintf(stderr, "fstat() failed with error (%d) %s\n",
|
|
errno, strerror(errno));
|
|
fprintf(stderr, "Error opening file '%s'\n", libtest_arg2);
|
|
fclose(hd_src);
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
if(!file_info.st_size) {
|
|
fprintf(stderr, "File %s has zero size!\n", libtest_arg2);
|
|
fclose(hd_src);
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
if(curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK) {
|
|
fprintf(stderr, "curl_global_init() failed\n");
|
|
fclose(hd_src);
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
/* get a curl handle */
|
|
curl = curl_easy_init();
|
|
if(!curl) {
|
|
fprintf(stderr, "curl_easy_init() failed\n");
|
|
curl_global_cleanup();
|
|
fclose(hd_src);
|
|
return TEST_ERR_MAJOR_BAD;
|
|
}
|
|
|
|
/* enable uploading */
|
|
test_setopt(curl, CURLOPT_UPLOAD, 1L);
|
|
|
|
/* enable verbose */
|
|
test_setopt(curl, CURLOPT_VERBOSE, 1L);
|
|
|
|
/* specify target */
|
|
test_setopt(curl, CURLOPT_URL, URL);
|
|
|
|
/* now specify which file to upload */
|
|
test_setopt(curl, CURLOPT_READDATA, hd_src);
|
|
|
|
/* Now run off and do what you've been told! */
|
|
res = curl_easy_perform(curl);
|
|
if(res)
|
|
goto test_cleanup;
|
|
|
|
/* and now upload the exact same again, but without rewinding so it already
|
|
is at end of file */
|
|
res = curl_easy_perform(curl);
|
|
|
|
test_cleanup:
|
|
|
|
/* close the local file */
|
|
fclose(hd_src);
|
|
|
|
curl_easy_cleanup(curl);
|
|
curl_global_cleanup();
|
|
|
|
return res;
|
|
}
|