curl/m4
Viktor Szakats 8db0e286b3
autotools: tidy-up if expressions
- drop x-hacks for curl internal variables and certain autotools ones
  that do not hold custom values.
- make x-hacks consistently use `"x$var" = "xval"` style.
- add a few x-hacks for input/external variables that may hold custom
  values.
- prefer `-z` and `-n` to test empty/non-empty.
  This also makes some x-hacks unnecessary.
- optimized negated test `-z` and `-n` options.
- prefer `&&` and `||` over `-a` and `-o`.
  For better POSIX compatibility:
  https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
- quote variables passed to `test`, where missing.
- quote string literals in comparisons.
- fix some indentation, whitespace.

Note that a few `case` statements also use the x-hack, which looks
unnecessary. This patch does not change them.

Verified by comparing feature detection results with a reference CI run
from before this patch (PR #19922).

Refs:
https://www.shellcheck.net/wiki/SC2268
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html
https://www.vidarholen.net/contents/blog/?p=1035
https://mywiki.wooledge.org/BashPitfalls#A.5B_.24foo_.3D_.22bar.22_.5D

Closes #18189
2025-12-10 22:29:19 +01:00
..
.gitignore tidy-up: .gitignore lines mostly 2025-01-27 20:59:46 +01:00
curl-amissl.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-apple-sectrust.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-compilers.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-confopts.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-functions.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-gnutls.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-mbedtls.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-openssl.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-override.m4 badwords: add more contractions, fix fallouts 2025-11-17 19:29:15 +01:00
curl-reentrant.m4 badwords: add more contractions, fix fallouts 2025-11-17 19:29:15 +01:00
curl-rustls.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-schannel.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-sysconfig.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
curl-wolfssl.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
xc-am-iface.m4 misc: cleanup after removing years from copyright 2024-07-30 14:11:48 +02:00
xc-cc-check.m4 misc: cleanup after removing years from copyright 2024-07-30 14:11:48 +02:00
xc-lt-iface.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
xc-val-flgs.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
zz40-xc-ovr.m4 autotools: tidy-up if expressions 2025-12-10 22:29:19 +01:00
zz50-xc-ovr.m4 badwords: add more contractions, fix fallouts 2025-11-17 19:29:15 +01:00