mirror of
https://github.com/curl/curl.git
synced 2026-08-07 02:39:06 +03:00
92f215fea1
`-Weverything` is not enabled by curl, and not recommended by LLVM, because it may enable experimental options, and will result in new fallouts after toolchain upgrades. This patch aims to fix/silence as much as possible as found with llvm/clang 21.1.0. It also permanently enables warnings that were fixed in source and deemed manageable in the future. `-Wformat` warnings are addressed separately via #18343. Fix/silence warnings in the source: - typecheck-gcc.h: fix `-Wreserved-identifier`. - lib: silence `-Wcast-function-type-strict`. For llvm 16+ or Apple clang 16+. - asyn-ares: limit `HAPPY_EYEBALLS_DNS_TIMEOUT` to old c-ares versions. - curl_trc: fix `-Wc++-hidden-decl`. - doh: fix `-Wc++-keyword`. - ftp: fix `-Wreserved-identifier`. - ldap: fix `-Wreserved-identifier`. - mqtt: comment unused macro to avoid warning. - multi_ev: drop unused macros to avoid warnings. - setopt: fix useless `break;` after `return;`. - gtls, mbedtls, rustls: silence `-Wconditional-uninitialized`. - socks_sspi, schannel, x509asn1: fix `-Wimplicit-int-enum-cast`. - x509asn1: fix `-Wc++-keyword`. - openssl: scope `OSSL_UI_METHOD_CAST` to avoid unused macro warning. - libssh2, wolfssl: drop unused macros. - curl_ngtcp2, curl_quiche, httpsrr, urlapi: drop/limit unused macros. - tool_getparam: fix useless `break;` after `return;` or `break;`. Not normally enabled because it doesn't work with unity. https://github.com/llvm/llvm-project/issues/71046 - tool_operate: fix `-Wc++-keyword`. - curlinfo: fix a `-Wunsafe-buffer-usage`. - tests: silence `-Wformat-non-iso`. - lib557: fix `-Wreserved-identifier`. - lib1565: silence `-Wconditional-uninitialized`. Enable the above clang warnings permanently in picky mode: - `-Wc++-hidden-decl` - `-Wc++-keyword` (except for Windows, where it collides with `wchar_t`) - `-Wcast-function-type-strict` - `-Wcast-function-type` - `-Wconditional-uninitialized` - `-Wformat-non-iso` (except for clang-cl) - `-Wreserved-identifier` - `-Wtentative-definition-compat` Silence problematic `-Weverything` warnings globally (in picky mode): - `-Wused-but-marked-unused` (88000+ hits) and `-Wdisabled-macro-expansion` (2600+ hits). Triggered by `typecheck-gcc.h` when building with clang 14+. Maybe there exists a way to fix within that header? Ref: https://discourse.llvm.org/t/removing-wused-but-marked-unused/55310 - `-Wunsafe-buffer-usage`. clang 16+. 7000+ hits. May be useful in theory, but such high volume of hits makes it impractical to review and possibly address. Meant for C++. Ref: https://clang.llvm.org/docs/SafeBuffers.html Ref: https://stackoverflow.com/questions/77017567/how-to-fix-code-to-avoid-warning-wunsafe-buffer-usage Ref: https://discourse.llvm.org/t/rfc-c-buffer-hardening/65734 Ref: https://github.com/llvm/llvm-project/pull/111624 - `-Wimplicit-void-ptr-cast`. clang 21+. 1700+ hits. C++ warning, deemed pure noise. Ref: https://github.com/curl/curl/issues/18470#issuecomment-3253506266 - `-Wswitch-default` (180+ hits), `-Wswitch-enum` (190+ hits), `-Wcovered-switch-default` (20+ hits). Next to impossible to fix cleanly, esp. when the covered `case` branches depend on compile-time options. - `-Wdocumentation-unknown-command` (8+ hits). Triggered in a few sources. Seems arbitrary and bogus. - `-Wpadded` (550+ hits). - `-Wc++-keyword` on Windows, where it collides with `wchar_t`. (100+ hits) Ref: https://github.com/llvm/llvm-project/issues/155988 - `-Wreserved-macro-identifier`. clang 13+. 5+ hits. Sometimes it's necessary to set external macros that use the reserved namespace. E.g. `_CRT_NONSTDC_NO_DEPRECATE`, `__ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED__`, `__NO_NET_API`, possibly `_REENTRANT`, and more. It's not worth trying to silence them individually. - `-Wnonportable-system-include-path` with `clang-cl`. It'd be broken by doing what the warning suggests. - `-Wformat-non-iso` for clang-cl. CMake `PICKY_COMPILER=ON` (the default) or `./configure` `--enable-warnings` (not the default) is required to enable these silencing rules. Also: - autotools, cmake: fix Apple clang and mainline llvm version translations. Ref: https://en.wikipedia.org/wiki/Xcode#Toolchain_versions - autotools, cmake: enable `-Warray-compare` for clang 20+. Follow-up to4b7accda5a#17196 - cmake: fix to enable `-Wmissing-variable-declarations` at an earlier clang version. - cmake: update internal logic to handle warning options with `+` in them. - cmake: fix internal logic to match the whole option when looking into `CMAKE_C_FLAGS` for custom-disabled warnings. Follow-up tob85cb8cb4e#18485 Closes #18477
95 lines
3.3 KiB
C
95 lines
3.3 KiB
C
#ifndef HEADER_CURL_X509ASN1_H
|
|
#define HEADER_CURL_X509ASN1_H
|
|
|
|
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
|
|
#include "../curl_setup.h"
|
|
|
|
#if defined(USE_GNUTLS) || defined(USE_WOLFSSL) || defined(USE_SCHANNEL) || \
|
|
defined(USE_MBEDTLS) || defined(USE_RUSTLS)
|
|
|
|
#include "../cfilters.h"
|
|
#include "../urldata.h"
|
|
|
|
/*
|
|
* Types.
|
|
*/
|
|
|
|
/* ASN.1 parsed element. */
|
|
struct Curl_asn1Element {
|
|
const char *header; /* Pointer to header byte. */
|
|
const char *beg; /* Pointer to element data. */
|
|
const char *end; /* Pointer to 1st byte after element. */
|
|
unsigned char eclass; /* ASN.1 element class. */
|
|
unsigned char tag; /* ASN.1 element tag. */
|
|
BIT(constructed); /* Element is constructed. */
|
|
};
|
|
|
|
/* X509 certificate: RFC 5280. */
|
|
struct Curl_X509certificate {
|
|
struct Curl_asn1Element certificate;
|
|
struct Curl_asn1Element version;
|
|
struct Curl_asn1Element serialNumber;
|
|
struct Curl_asn1Element signatureAlgorithm;
|
|
struct Curl_asn1Element signature;
|
|
struct Curl_asn1Element issuer;
|
|
struct Curl_asn1Element notBefore;
|
|
struct Curl_asn1Element notAfter;
|
|
struct Curl_asn1Element subject;
|
|
struct Curl_asn1Element subjectPublicKeyInfo;
|
|
struct Curl_asn1Element subjectPublicKeyAlgorithm;
|
|
struct Curl_asn1Element subjectPublicKey;
|
|
struct Curl_asn1Element issuerUniqueID;
|
|
struct Curl_asn1Element subjectUniqueID;
|
|
struct Curl_asn1Element extensions;
|
|
};
|
|
|
|
/*
|
|
* Prototypes.
|
|
*/
|
|
|
|
int Curl_parseX509(struct Curl_X509certificate *cert,
|
|
const char *beg, const char *end);
|
|
CURLcode Curl_extract_certinfo(struct Curl_easy *data, int certnum,
|
|
const char *beg, const char *end);
|
|
CURLcode Curl_verifyhost(struct Curl_cfilter *cf, struct Curl_easy *data,
|
|
const char *beg, const char *end);
|
|
|
|
#ifdef UNITTESTS
|
|
#if defined(USE_GNUTLS) || defined(USE_SCHANNEL) || defined(USE_MBEDTLS) || \
|
|
defined(USE_RUSTLS)
|
|
|
|
/* used by unit1656.c */
|
|
CURLcode Curl_x509_GTime2str(struct dynbuf *store,
|
|
const char *beg, const char *end);
|
|
/* used by unit1657.c */
|
|
CURLcode Curl_x509_getASN1Element(struct Curl_asn1Element *elem,
|
|
const char *beg, const char *end);
|
|
#endif
|
|
#endif
|
|
|
|
#endif /* USE_GNUTLS or USE_WOLFSSL or USE_SCHANNEL or USE_MBEDTLS or
|
|
USE_RUSTLS */
|
|
#endif /* HEADER_CURL_X509ASN1_H */
|