mirror of
https://github.com/curl/curl.git
synced 2026-04-30 08:27:50 +03:00
The issues found fell into these categories, with the applied fixes:
- const was accidentally stripped.
Adjust code to not cast or cast with const.
- const/volatile missing from arguments, local variables.
Constify arguments or variables, adjust/delete casts. Small code
changes in a few places.
- const must be stripped because an API dependency requires it.
Strip `const` with `CURL_UNCONST()` macro to silence the warning out
of our control. These happen at API boundaries. Sometimes they depend
on dependency version, which this patch handles as necessary. Also
enable const support for the zlib API, using `ZLIB_CONST`. Supported
by zlib 1.2.5.2 and newer.
- const must be stripped because a curl API requires it.
Strip `const` with `CURL_UNCONST()` macro to silence the warning out
of our immediate control. For example we promise to send a non-const
argument to a callback, though the data is const internally.
- other cases where we may avoid const stripping by code changes.
Also silenced with `CURL_UNCONST()`.
- there are 3 places where `CURL_UNCONST()` is cast again to const.
To silence this type of warning:
```
lib/vquic/curl_osslq.c:1015:29: error: to be safe all intermediate
pointers in cast from 'unsigned char **' to 'const unsigned char **'
must be 'const' qualified [-Werror=cast-qual]
lib/cf-socket.c:734:32: error: to be safe all intermediate pointers in
cast from 'char **' to 'const char **' must be 'const' qualified
[-Werror=cast-qual]
```
There may be a better solution, but I couldn't find it.
These cases are handled in separate subcommits, but without further
markup.
If you see a `-Wcast-qual` warning in curl, we appreciate your report
about it.
Closes #16142
156 lines
5.6 KiB
C
156 lines
5.6 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "tool_filetime.h"
|
|
#include "tool_cfgable.h"
|
|
#include "tool_msgs.h"
|
|
#include "curlx.h"
|
|
|
|
#ifdef HAVE_UTIME_H
|
|
# include <utime.h>
|
|
#elif defined(HAVE_SYS_UTIME_H)
|
|
# include <sys/utime.h>
|
|
#endif
|
|
|
|
/* Returns 0 on success, non-zero on file problems */
|
|
int getfiletime(const char *filename, struct GlobalConfig *global,
|
|
curl_off_t *stamp)
|
|
{
|
|
int rc = 1;
|
|
|
|
/* Windows stat() may attempt to adjust the Unix GMT file time by a daylight
|
|
saving time offset and since it is GMT that is bad behavior. When we have
|
|
access to a 64-bit type we can bypass stat and get the times directly. */
|
|
#if defined(_WIN32) && !defined(CURL_WINDOWS_UWP)
|
|
HANDLE hfile;
|
|
TCHAR *tchar_filename = curlx_convert_UTF8_to_tchar(filename);
|
|
|
|
hfile = CreateFile(tchar_filename, FILE_READ_ATTRIBUTES,
|
|
(FILE_SHARE_READ | FILE_SHARE_WRITE |
|
|
FILE_SHARE_DELETE),
|
|
NULL, OPEN_EXISTING, 0, NULL);
|
|
curlx_unicodefree(tchar_filename);
|
|
if(hfile != INVALID_HANDLE_VALUE) {
|
|
FILETIME ft;
|
|
if(GetFileTime(hfile, NULL, NULL, &ft)) {
|
|
curl_off_t converted = (curl_off_t)ft.dwLowDateTime
|
|
| ((curl_off_t)ft.dwHighDateTime) << 32;
|
|
|
|
if(converted < CURL_OFF_T_C(116444736000000000))
|
|
warnf(global, "Failed to get filetime: underflow");
|
|
else {
|
|
*stamp = (converted - CURL_OFF_T_C(116444736000000000)) / 10000000;
|
|
rc = 0;
|
|
}
|
|
}
|
|
else {
|
|
warnf(global, "Failed to get filetime: "
|
|
"GetFileTime failed: GetLastError %u",
|
|
(unsigned int)GetLastError());
|
|
}
|
|
CloseHandle(hfile);
|
|
}
|
|
else if(GetLastError() != ERROR_FILE_NOT_FOUND) {
|
|
warnf(global, "Failed to get filetime: "
|
|
"CreateFile failed: GetLastError %u",
|
|
(unsigned int)GetLastError());
|
|
}
|
|
#else
|
|
struct_stat statbuf;
|
|
if(-1 != stat(filename, &statbuf)) {
|
|
*stamp = (curl_off_t)statbuf.st_mtime;
|
|
rc = 0;
|
|
}
|
|
else
|
|
warnf(global, "Failed to get filetime: %s", strerror(errno));
|
|
#endif
|
|
return rc;
|
|
}
|
|
|
|
#if defined(HAVE_UTIME) || defined(HAVE_UTIMES) || defined(_WIN32)
|
|
void setfiletime(curl_off_t filetime, const char *filename,
|
|
struct GlobalConfig *global)
|
|
{
|
|
if(filetime >= 0) {
|
|
/* Windows utime() may attempt to adjust the Unix GMT file time by a daylight
|
|
saving time offset and since it is GMT that is bad behavior. When we have
|
|
access to a 64-bit type we can bypass utime and set the times directly. */
|
|
#if defined(_WIN32) && !defined(CURL_WINDOWS_UWP)
|
|
HANDLE hfile;
|
|
TCHAR *tchar_filename = curlx_convert_UTF8_to_tchar(filename);
|
|
|
|
/* 910670515199 is the maximum Unix filetime that can be used as a
|
|
Windows FILETIME without overflow: 30827-12-31T23:59:59. */
|
|
if(filetime > CURL_OFF_T_C(910670515199)) {
|
|
warnf(global, "Failed to set filetime %" CURL_FORMAT_CURL_OFF_T
|
|
" on outfile: overflow", filetime);
|
|
curlx_unicodefree(tchar_filename);
|
|
return;
|
|
}
|
|
|
|
hfile = CreateFile(tchar_filename, FILE_WRITE_ATTRIBUTES,
|
|
(FILE_SHARE_READ | FILE_SHARE_WRITE |
|
|
FILE_SHARE_DELETE),
|
|
NULL, OPEN_EXISTING, 0, NULL);
|
|
curlx_unicodefree(tchar_filename);
|
|
if(hfile != INVALID_HANDLE_VALUE) {
|
|
curl_off_t converted = ((curl_off_t)filetime * 10000000) +
|
|
CURL_OFF_T_C(116444736000000000);
|
|
FILETIME ft;
|
|
ft.dwLowDateTime = (DWORD)(converted & 0xFFFFFFFF);
|
|
ft.dwHighDateTime = (DWORD)(converted >> 32);
|
|
if(!SetFileTime(hfile, NULL, &ft, &ft)) {
|
|
warnf(global, "Failed to set filetime %" CURL_FORMAT_CURL_OFF_T
|
|
" on outfile: SetFileTime failed: GetLastError %u",
|
|
filetime, (unsigned int)GetLastError());
|
|
}
|
|
CloseHandle(hfile);
|
|
}
|
|
else {
|
|
warnf(global, "Failed to set filetime %" CURL_FORMAT_CURL_OFF_T
|
|
" on outfile: CreateFile failed: GetLastError %u",
|
|
filetime, (unsigned int)GetLastError());
|
|
}
|
|
|
|
#elif defined(HAVE_UTIMES)
|
|
struct timeval times[2];
|
|
times[0].tv_sec = times[1].tv_sec = (time_t)filetime;
|
|
times[0].tv_usec = times[1].tv_usec = 0;
|
|
if(utimes(filename, times)) {
|
|
warnf(global, "Failed to set filetime %" CURL_FORMAT_CURL_OFF_T
|
|
" on '%s': %s", filetime, filename, strerror(errno));
|
|
}
|
|
|
|
#elif defined(HAVE_UTIME)
|
|
struct utimbuf times;
|
|
times.actime = (time_t)filetime;
|
|
times.modtime = (time_t)filetime;
|
|
if(utime(filename, ×)) {
|
|
warnf(global, "Failed to set filetime %" CURL_FORMAT_CURL_OFF_T
|
|
" on '%s': %s", filetime, filename, strerror(errno));
|
|
}
|
|
#endif
|
|
}
|
|
}
|
|
#endif /* defined(HAVE_UTIME) || defined(HAVE_UTIMES) || \
|
|
defined(_WIN32) */
|