mirror of
https://github.com/curl/curl.git
synced 2026-06-22 12:55:39 +03:00
Before this patch curl used the C preprocessor to override standard memory allocation symbols: malloc, calloc, strdup, realloc, free. The goal of these is to replace them with curl's debug wrappers in `CURLDEBUG` builds, another was to replace them with the wrappers calling user-defined allocators in libcurl. This solution needed a bunch of workarounds to avoid breaking external headers: it relied on include order to do the overriding last. For "unity" builds it needed to reset overrides before external includes. Also in test apps, which are always built as single source files. It also needed the `(symbol)` trick to avoid overrides in some places. This would still not fix cases where the standard symbols were macros. It was also fragile and difficult to figure out which was the actual function behind an alloc or free call in a specific piece of code. This in turn caused bugs where the wrong allocator was accidentally called. To avoid these problems, this patch replaces this solution with `curlx_`-prefixed allocator macros, and mapping them _once_ to either the libcurl wrappers, the debug wrappers or the standard ones, matching the rest of the code in libtests. This concludes the long journey to avoid redefining standard functions in the curl codebase. Note: I did not update `packages/OS400/*.c` sources. They did not `#include` `curl_setup.h`, `curl_memory.h` or `memdebug.h`, meaning the overrides were never applied to them. This may or may not have been correct. For now I suppressed the direct use of standard allocators via a local `.checksrc`. Probably they (except for `curlcl.c`) should be updated to include `curl_setup.h` and use the `curlx_` macros. This patch changes mappings in two places: - `lib/curl_threads.c` in libtests: Before this patch it mapped to libcurl allocators. After, it maps to standard allocators, like the rest of libtests code. - `units`: before this patch it mapped to standard allocators. After, it maps to libcurl allocators. Also: - drop all position-dependent `curl_memory.h` and `memdebug.h` includes, and delete the now unnecessary headers. - rename `Curl_tcsdup` macro to `curlx_tcsdup` and define like the other allocators. - map `curlx_strdup()` to `_strdup()` on Windows (was: `strdup()`). To fix warnings silenced via `_CRT_NONSTDC_NO_DEPRECATE`. - multibyte: map `curlx_convert_*()` to `_strdup()` on Windows (was: `strdup()`). - src: do not reuse the `strdup` name for the local replacement. - lib509: call `_strdup()` on Windows (was: `strdup()`). - test1132: delete test obsoleted by this patch. - CHECKSRC.md: update text for `SNPRINTF`. - checksrc: ban standard allocator symbols. Follow-up tob12da22db1#18866 Follow-up todb98daab05#18844 Follow-up to4deea9396b#18814 Follow-up to9678ff5b1b#18776 Follow-up to10bac43b87#18774 Follow-up to20142f5d06#18634 Follow-up tobf7375ecc5#18503 Follow-up to9863599d69#18502 Follow-up to3bb5e58c10#17827 Closes #19626
127 lines
3.6 KiB
C
127 lines
3.6 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "tool_setup.h"
|
|
|
|
#include "tool_util.h"
|
|
|
|
#ifdef _WIN32
|
|
|
|
struct timeval tvrealnow(void)
|
|
{
|
|
/* UNIX EPOCH (1970-01-01) in FILETIME (1601-01-01) as 64-bit value */
|
|
static const uint64_t EPOCH = UINT64_C(116444736000000000);
|
|
SYSTEMTIME systime;
|
|
FILETIME ftime; /* 100ns since 1601-01-01, as double 32-bit value */
|
|
uint64_t time; /* 100ns since 1601-01-01, as 64-bit value */
|
|
struct timeval now;
|
|
|
|
GetSystemTime(&systime);
|
|
SystemTimeToFileTime(&systime, &ftime);
|
|
time = ((uint64_t)ftime.dwLowDateTime);
|
|
time += ((uint64_t)ftime.dwHighDateTime) << 32;
|
|
|
|
now.tv_sec = (long)((time - EPOCH) / 10000000L); /* unit is 100ns */
|
|
now.tv_usec = (long)(systime.wMilliseconds * 1000);
|
|
return now;
|
|
}
|
|
|
|
#else
|
|
|
|
struct timeval tvrealnow(void)
|
|
{
|
|
struct timeval now;
|
|
#ifdef HAVE_GETTIMEOFDAY
|
|
(void)gettimeofday(&now, NULL);
|
|
#else
|
|
now.tv_sec = time(NULL);
|
|
now.tv_usec = 0;
|
|
#endif
|
|
return now;
|
|
}
|
|
|
|
#endif
|
|
|
|
/* Case insensitive compare. Accept NULL pointers. */
|
|
int struplocompare(const char *p1, const char *p2)
|
|
{
|
|
if(!p1)
|
|
return p2 ? -1 : 0;
|
|
if(!p2)
|
|
return 1;
|
|
return CURL_STRICMP(p1, p2);
|
|
}
|
|
|
|
/* Indirect version to use as qsort callback. */
|
|
int struplocompare4sort(const void *p1, const void *p2)
|
|
{
|
|
return struplocompare(* (char * const *) p1, * (char * const *) p2);
|
|
}
|
|
|
|
#ifdef USE_TOOL_FTRUNCATE
|
|
/*
|
|
* Truncate a file handle at a 64-bit position 'where'.
|
|
*/
|
|
int tool_ftruncate64(int fd, curl_off_t where)
|
|
{
|
|
intptr_t handle = _get_osfhandle(fd);
|
|
|
|
if(_lseeki64(fd, where, SEEK_SET) < 0)
|
|
return -1;
|
|
|
|
if(!SetEndOfFile((HANDLE)handle))
|
|
return -1;
|
|
|
|
return 0;
|
|
}
|
|
#endif /* USE_TOOL_FTRUNCATE */
|
|
|
|
#ifdef _WIN32
|
|
FILE *tool_execpath(const char *filename, char **pathp)
|
|
{
|
|
static char filebuffer[512];
|
|
unsigned long len;
|
|
/* Get the filename of our executable. GetModuleFileName is already declared
|
|
* via inclusions done in setup header file. We assume that we are using
|
|
* the ASCII version here.
|
|
*/
|
|
len = GetModuleFileNameA(0, filebuffer, sizeof(filebuffer));
|
|
if(len > 0 && len < sizeof(filebuffer)) {
|
|
/* We got a valid filename - get the directory part */
|
|
char *lastdirchar = strrchr(filebuffer, DIR_CHAR[0]);
|
|
if(lastdirchar) {
|
|
size_t remaining;
|
|
*lastdirchar = 0;
|
|
/* If we have enough space, build the RC filename */
|
|
remaining = sizeof(filebuffer) - strlen(filebuffer);
|
|
if(strlen(filename) < remaining - 1) {
|
|
curl_msnprintf(lastdirchar, remaining, "%s%s", DIR_CHAR, filename);
|
|
*pathp = filebuffer;
|
|
return curlx_fopen(filebuffer, FOPEN_READTEXT);
|
|
}
|
|
}
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
#endif
|