mirror of
https://github.com/curl/curl.git
synced 2026-07-10 11:57:16 +03:00
39dec13ec0
Also repurpose existing build-time feature checks into unit test 1961,
to verify.
Prior to this patch these functions were auto-detected with both
autotools and cmake. In case of autotools there was an extra
verification phase ensuring the functions work as expected. This step
required running the function, thus was limited to non-cross-builds. For
cross-builds and CMake it always used the system implementation if
present. On Windows it always used the local implementation, because
availability/use is complicated there.
After this patch all platforms, always use the local implementation,
which is known to be accurate. This makes curl behave more consistently,
and simplifies the build process, a fixes cross-builds and CMake
auto-detection differences.
Also:
- test1960: enable unconditionally.
- checksrc: disallow globally, allowlist in `block_ip.c` example.
- dnsd: verify ntop result for NULL before passing to printf.
Ref: https://github.com/curl/curl/pull/22137#issuecomment-4797440983
Ref: #22137
Ref: 8537a5b0bc #16577
Closes #22170
137 lines
4 KiB
C
137 lines
4 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
#include "first.h"
|
|
|
|
#ifdef HAVE_NETINET_IN_H
|
|
#include <netinet/in.h>
|
|
#endif
|
|
#ifdef HAVE_ARPA_INET_H
|
|
#include <arpa/inet.h>
|
|
#endif
|
|
|
|
/* to prevent libcurl from closing our socket */
|
|
static int closesocket_cb(void *clientp, curl_socket_t item)
|
|
{
|
|
(void)clientp;
|
|
(void)item;
|
|
return 0;
|
|
}
|
|
|
|
/* provide our own socket */
|
|
static curl_socket_t socket_cb(void *clientp,
|
|
curlsocktype purpose,
|
|
struct curl_sockaddr *address)
|
|
{
|
|
int s = *(int *)clientp;
|
|
(void)purpose;
|
|
(void)address;
|
|
return (curl_socket_t)s;
|
|
}
|
|
|
|
/* tell libcurl the socket is connected */
|
|
static int sockopt_cb(void *clientp,
|
|
curl_socket_t curlfd,
|
|
curlsocktype purpose)
|
|
{
|
|
(void)clientp;
|
|
(void)curlfd;
|
|
(void)purpose;
|
|
return CURL_SOCKOPT_ALREADY_CONNECTED;
|
|
}
|
|
|
|
/* Expected args: URL IP PORT */
|
|
static CURLcode test_lib1960(const char *URL)
|
|
{
|
|
CURL *curl = NULL;
|
|
CURLcode result = TEST_ERR_MAJOR_BAD;
|
|
int status;
|
|
curl_socket_t client_fd = CURL_SOCKET_BAD;
|
|
struct sockaddr_in serv_addr;
|
|
curl_off_t port;
|
|
|
|
if(!strcmp("check", URL))
|
|
return CURLE_OK; /* no output makes it not skipped */
|
|
|
|
if(curlx_str_number(&libtest_arg3, &port, 0xffff))
|
|
return result;
|
|
|
|
if(curl_global_init(CURL_GLOBAL_ALL) != CURLE_OK) {
|
|
curl_mfprintf(stderr, "curl_global_init() failed\n");
|
|
return result;
|
|
}
|
|
|
|
/*
|
|
* This code connects to the TCP port "manually" so that we then can hand
|
|
* over this socket as "already connected" to libcurl and make sure that
|
|
* this works.
|
|
*/
|
|
client_fd = CURL_SOCKET(AF_INET, SOCK_STREAM, 0);
|
|
if(client_fd == CURL_SOCKET_BAD) {
|
|
curl_mfprintf(stderr, "socket creation error\n");
|
|
goto test_cleanup;
|
|
}
|
|
|
|
memset(&serv_addr, 0, sizeof(serv_addr));
|
|
serv_addr.sin_family = AF_INET;
|
|
serv_addr.sin_port = htons((unsigned short)port);
|
|
|
|
if(curlx_inet_pton(AF_INET, libtest_arg2, &serv_addr.sin_addr) <= 0) {
|
|
curl_mfprintf(stderr, "curlx_inet_pton() failed\n");
|
|
goto test_cleanup;
|
|
}
|
|
|
|
status = connect(client_fd, (struct sockaddr *)&serv_addr,
|
|
sizeof(serv_addr));
|
|
if(status < 0) {
|
|
curl_mfprintf(stderr, "connection failed\n");
|
|
goto test_cleanup;
|
|
}
|
|
|
|
curl = curl_easy_init();
|
|
if(!curl) {
|
|
curl_mfprintf(stderr, "curl_easy_init() failed\n");
|
|
goto test_cleanup;
|
|
}
|
|
|
|
easy_setopt(curl, CURLOPT_VERBOSE, 1L);
|
|
easy_setopt(curl, CURLOPT_OPENSOCKETFUNCTION, socket_cb);
|
|
easy_setopt(curl, CURLOPT_OPENSOCKETDATA, &client_fd);
|
|
easy_setopt(curl, CURLOPT_SOCKOPTFUNCTION, sockopt_cb);
|
|
easy_setopt(curl, CURLOPT_SOCKOPTDATA, NULL);
|
|
easy_setopt(curl, CURLOPT_CLOSESOCKETFUNCTION, closesocket_cb);
|
|
easy_setopt(curl, CURLOPT_CLOSESOCKETDATA, NULL);
|
|
easy_setopt(curl, CURLOPT_VERBOSE, 1L);
|
|
easy_setopt(curl, CURLOPT_HEADER, 1L);
|
|
easy_setopt(curl, CURLOPT_URL, URL);
|
|
|
|
result = curl_easy_perform(curl);
|
|
|
|
test_cleanup:
|
|
curl_easy_cleanup(curl);
|
|
if(client_fd != CURL_SOCKET_BAD)
|
|
sclose(client_fd);
|
|
curl_global_cleanup();
|
|
|
|
return result;
|
|
}
|