mirror of
https://github.com/curl/curl.git
synced 2026-04-14 22:31:41 +03:00
6d0ee7b17b
Move existing `Curl_rename()` `rename()` wrapper from lib to curlx/fopen, and make it a curlx macro/function. To allow using the local worker function to fixup long filenames on Windows. Then fix the Windows-specific rename implementation to support long filenames. This operation may happen when using a cookie jar, HSTS cache or alt-svc cache, via libcurl or the curl tool. Before this patch, when passing a long filename to the above options, a `<random>.tmp` file was left on the disk without renaming it to the filename passed to curl. There was also 1 second delay for each attempted rename operation. Also: - checksrc: ban raw `rename()` and `MoveFileEx*()` functions. - Note: `Curl_rename()` returned 1 on failure before this patch, while `curlx_rename()` returns -1 after, to match POSIX `rename()`. Refs: https://learn.microsoft.com/windows/win32/api/winbase/nf-winbase-movefileexa https://learn.microsoft.com/windows/win32/fileio/maximum-file-path-limitation Ref: #20040 Closes #20042
79 lines
3.2 KiB
C
79 lines
3.2 KiB
C
#ifndef HEADER_CURLX_FOPEN_H
|
|
#define HEADER_CURLX_FOPEN_H
|
|
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
|
|
#include "../curl_setup.h"
|
|
|
|
#include "multibyte.h"
|
|
|
|
#ifdef HAVE_FCNTL_H
|
|
#include <fcntl.h> /* for open() and attributes */
|
|
#endif
|
|
|
|
int curlx_fseek(void *stream, curl_off_t offset, int whence);
|
|
|
|
#ifdef _WIN32
|
|
#ifndef CURL_WINDOWS_UWP
|
|
HANDLE curlx_CreateFile(const char *filename,
|
|
DWORD dwDesiredAccess,
|
|
DWORD dwShareMode,
|
|
LPSECURITY_ATTRIBUTES lpSecurityAttributes,
|
|
DWORD dwCreationDisposition,
|
|
DWORD dwFlagsAndAttributes,
|
|
HANDLE hTemplateFile);
|
|
#endif /* !CURL_WINDOWS_UWP */
|
|
FILE *curlx_win32_fopen(const char *filename, const char *mode);
|
|
FILE *curlx_win32_freopen(const char *filename, const char *mode, FILE *fh);
|
|
int curlx_win32_stat(const char *path, struct_stat *buffer);
|
|
int curlx_win32_open(const char *filename, int oflag, ...);
|
|
int curlx_win32_rename(const char *oldpath, const char *newpath);
|
|
#define CURLX_FOPEN_LOW(fname, mode) curlx_win32_fopen(fname, mode)
|
|
#define CURLX_FREOPEN_LOW(fname, mode, fh) curlx_win32_freopen(fname, mode, fh)
|
|
#define curlx_stat(fname, stp) curlx_win32_stat(fname, stp)
|
|
#define curlx_open curlx_win32_open
|
|
#define curlx_rename curlx_win32_rename
|
|
#else
|
|
#define CURLX_FOPEN_LOW fopen
|
|
#define CURLX_FREOPEN_LOW freopen
|
|
#define curlx_stat(fname, stp) stat(fname, stp)
|
|
#define curlx_open open
|
|
#define curlx_rename rename
|
|
#endif
|
|
|
|
#ifdef CURLDEBUG
|
|
#define curlx_fopen(file, mode) curl_dbg_fopen(file, mode, __LINE__, __FILE__)
|
|
#define curlx_freopen(file, mode, fh) \
|
|
curl_dbg_freopen(file, mode, fh, __LINE__, __FILE__)
|
|
#define curlx_fdopen(file, mode) \
|
|
curl_dbg_fdopen(file, mode, __LINE__, __FILE__)
|
|
#define curlx_fclose(file) curl_dbg_fclose(file, __LINE__, __FILE__)
|
|
#else
|
|
#define curlx_fopen CURLX_FOPEN_LOW
|
|
#define curlx_freopen CURLX_FREOPEN_LOW
|
|
#define curlx_fdopen fdopen
|
|
#define curlx_fclose fclose
|
|
#endif
|
|
|
|
#endif /* HEADER_CURLX_FOPEN_H */
|