mirror of
https://github.com/curl/curl.git
synced 2026-06-18 11:55:40 +03:00
0ffab25b6c
- `N byte` -> `N-byte` or `N bytes`. - INTERNALS.md: language tweaks. - schannel: language tweak in comment/error message. - socks_gssapi, socks_sspi: simplify composing an error message. (at a cost of 8 extra constant string bytes.) - m4/curl-compilers.m4: fix typo in link (in comment). - contrithanks.sh: fix indent, drop stray `;` terminator. - lib, src, tests: drop/fix a bunch of badwords. - fix typos in comments. - fix indent, stray spaces. Some of these spotted by GitHub Code Quality and Copilot Closes #22009
119 lines
4.6 KiB
C
119 lines
4.6 KiB
C
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
/*
|
|
* See https://github.com/curl/curl/issues/3371
|
|
*
|
|
* This test case checks whether curl_multi_remove_handle() cancels
|
|
* asynchronous DNS resolvers without blocking where possible. Obviously, it
|
|
* only tests whichever resolver curl is actually built with.
|
|
*/
|
|
|
|
/* We are waiting a generous two seconds for the removal. This is as low as we
|
|
can go while still easily supporting SIGALRM timing for the non-threaded
|
|
blocking resolver. It does not matter that much because when the test
|
|
passes, we never wait this long. We set it much higher via the default
|
|
TEST_HANG_TIMEOUT to avoid issues when running on overloaded CI machines. */
|
|
|
|
#include "first.h"
|
|
|
|
static CURLcode test_lib1592(const char *URL)
|
|
{
|
|
int stillRunning;
|
|
CURLM *multi = NULL;
|
|
CURL *curl = NULL;
|
|
CURLcode result = CURLE_OK;
|
|
CURLMcode mresult;
|
|
long timeout;
|
|
|
|
global_init(CURL_GLOBAL_ALL);
|
|
|
|
multi_init(multi);
|
|
|
|
easy_init(curl);
|
|
|
|
easy_setopt(curl, CURLOPT_VERBOSE, 1L);
|
|
easy_setopt(curl, CURLOPT_URL, URL);
|
|
|
|
/* Set a DNS server that hopefully does not respond when using c-ares. */
|
|
if(curl_easy_setopt(curl, CURLOPT_DNS_SERVERS, "0.0.0.0") == CURLE_OK)
|
|
/* Since we could set the DNS server, presume we are working with a
|
|
resolver that can be cancelled (i.e. c-ares). Thus,
|
|
curl_multi_remove_handle() should not block even when the resolver
|
|
request is outstanding. Thus, set a request timeout _longer_ than the
|
|
test hang timeout so we fail if the handle removal call incorrectly
|
|
blocks. */
|
|
timeout = TEST_HANG_TIMEOUT * 2;
|
|
else {
|
|
/* If we cannot set the DNS server, presume that we are configured to use
|
|
a resolver that cannot be cancelled (i.e. the threaded resolver or the
|
|
non-threaded blocking resolver). Thus, we test that the
|
|
curl_multi_remove_handle() call does finish well within our test
|
|
timeout.
|
|
|
|
But, it is unlikely that the resolver request takes any time at
|
|
all because we have not been able to configure the resolver to use an
|
|
non-responsive DNS server. At least we exercise the flow. */
|
|
curl_mfprintf(stderr,
|
|
"CURLOPT_DNS_SERVERS not supported; "
|
|
"assuming curl_multi_remove_handle() does block\n");
|
|
timeout = TEST_HANG_TIMEOUT / 2;
|
|
}
|
|
|
|
/* Setting a timeout on the request should ensure that even if we have to
|
|
wait for the resolver during curl_multi_remove_handle(), it does not take
|
|
longer than this, because the resolver request inherits its timeout from
|
|
this. */
|
|
easy_setopt(curl, CURLOPT_TIMEOUT_MS, timeout);
|
|
|
|
multi_add_handle(multi, curl);
|
|
|
|
/* This should move the handle from INIT => CONNECT => WAITRESOLVE. */
|
|
curl_mfprintf(stderr, "curl_multi_perform()...\n");
|
|
multi_perform(multi, &stillRunning);
|
|
curl_mfprintf(stderr, "curl_multi_perform() succeeded\n");
|
|
|
|
/* Start measuring how long it takes to remove the handle. */
|
|
curl_mfprintf(stderr, "curl_multi_remove_handle()...\n");
|
|
start_test_timing();
|
|
mresult = curl_multi_remove_handle(multi, curl);
|
|
if(mresult) {
|
|
curl_mfprintf(stderr, "curl_multi_remove_handle() failed, with code %d\n",
|
|
mresult);
|
|
result = TEST_ERR_MULTI;
|
|
goto test_cleanup;
|
|
}
|
|
curl_mfprintf(stderr, "curl_multi_remove_handle() succeeded\n");
|
|
|
|
/* Fail the test if it took too long to remove. This happens after the fact,
|
|
and says "it seems that it would have run forever", which is not true, but
|
|
it is close enough, and simple to do. */
|
|
abort_on_test_timeout();
|
|
|
|
test_cleanup:
|
|
curl_easy_cleanup(curl);
|
|
curl_multi_cleanup(multi);
|
|
curl_global_cleanup();
|
|
|
|
return result;
|
|
}
|