Daniel Stenberg
e683182918
imap: remove duplicated function
...
The list and search response functions were identical! Merged into one
now. Detected by PVS Studio.
Reported-by: Alexis La Goutte
2016-03-31 15:12:22 +02:00
Daniel Stenberg
0ee0d30a9f
SOCKS5_gssapi_negotiate: don't assume little-endian ints
...
The code copied one byte from a 32bit integer, which works fine as long
as the byte order is the same. Not a fine assumption. Reported by PVS
Studio.
Reported-by: Alexis La Goutte
2016-03-31 10:22:42 +02:00
Daniel Stenberg
541027876d
http: remove ((expression)) double parentheses
2016-03-31 10:10:58 +02:00
Daniel Stenberg
b22a954736
Curl_add_buffer_send: avoid possible NULL dereference
...
... as we check for a NULL pointer below, we move the derefence to after
the check. Detected by PVS Studio.
Reported-by: Alexis La Goutte
2016-03-31 10:10:58 +02:00
Daniel Stenberg
b3912d9dd7
file: remove duplicate checks of the same variable
...
... as it doesn't change in between. Deteced by PVS Studio.
Reported-by: Alexis La Goutte
2016-03-31 10:10:58 +02:00
Marcel Raad
4dae049157
openssl: Fix compilation warnings
...
When compiling with OpenSSL 1.1.0 (so that the HAVE_X509_GET0_SIGNATURE
&& HAVE_X509_GET0_EXTENSIONS pre-processor block is active), Visual C++
14 complains:
warning C4701: potentially uninitialized local variable 'palg' used
warning C4701: potentially uninitialized local variable 'psig' used
2016-03-30 23:55:00 +01:00
Daniel Stenberg
575e885db0
multi: turn Curl_done into file local multi_done
...
... as it now is used by multi.c only.
2016-03-30 07:52:28 +02:00
Daniel Stenberg
93935c08c1
multi: multi_reconnect_request is the former Curl_reconnect_request
...
now a file local function in multi.c
2016-03-30 07:52:28 +02:00
Daniel Stenberg
6b61d8160d
multi: move Curl_do and Curl_do_done to multi.c and make static
...
... called multi_do and multi_do_done as they're file local now.
2016-03-30 07:52:28 +02:00
Jay Satiro
7921628714
wolfssl: Use ECC supported curves extension
...
https://github.com/wolfSSL/wolfssl/issues/366
2016-03-29 19:06:55 -04:00
Isaac Boukris
d5fc6e14b0
GSS: make Curl_gss_log_error more verbose
...
Also display the GSS_C_GSS_CODE (major code) when specified instead of
only GSS_C_MECH_CODE (minor code).
In addition, the old code was printing a colon twice after the prefix
and also miscalculated the length of the buffer in between calls to
gss_display_status (the length of ": " was missing).
Also, gss_buffer is not guaranteed to be NULL terminated and thus need
to restrict reading by its length.
Closes #738
2016-03-29 16:51:29 +02:00
Daniel Stenberg
1fc767210c
http2: set correct scheme in handler structs [regression]
...
Since commit a5aec58 the handler schemes need to match for the
connections to be reused and for HTTP/2 multiplexing to work, reusing
connections is very important!
Closes #736
2016-03-29 16:08:38 +02:00
Daniel Stenberg
2505fbbdb5
hostip.c: minor white space edit for style
2016-03-29 15:19:21 +02:00
Jay Satiro
a43b22e05b
wolfssl: Add ALPN support
2016-03-28 18:18:09 -04:00
Steve Holme
f0bdd72c10
http_ntlm: Renamed from curl_ntlm.[c|h]
...
Renamed the header and source files for this module as they are HTTP
specific and as such, they should use the naming convention as other
HTTP authentication source files do - this revert commit 260ee6b7bf .
Note: We could also rename curl_ntlm_wb.[c|h], however, the Winbind
code needs separating from the HTTP protocol and migrating into the
vauth directory, thus adding support for Winbind to the SASL based
protocols such as IMAP, POP3 and SMTP.
2016-03-27 17:58:50 +01:00
marquis-de-muesli
39bb73665c
SSH: new CURLOPT_QUOTE command "statvfs"
...
usage: "statvfs path"
returns remote file system statistics
2016-03-27 17:52:16 +02:00
marquis-de-muesli
f9d27e0f8e
SSH: support CURLINFO_FILETIME
2016-03-27 17:52:16 +02:00
Jay Satiro
3d144ab99b
url: don't use bad offset in tld_check_name to show error
...
libidn's tld_check_lz returns an error offset of the first character
that it failed to process, however that offset is not a byte offset and
may not even be in the locale encoding therefore we can't use it to show
the user the character that failed to process.
Bug: https://github.com/curl/curl/issues/731
Reported-by: Karlson2k
2016-03-26 14:41:35 -04:00
Steve Holme
4adee1947c
http_negotiate: Combine GSS-API and SSPI source files
...
As the GSS-API and SSPI based source files are no longer library/API
specific, following the extraction of that authentication code to the
vauth directory, combine these files rather than maintain two separate
versions.
2016-03-26 17:21:22 +00:00
Steve Holme
6d6f9ca1d9
vauth: Moved the Negotiate authentication code to the new vauth directory
...
Part 2 of 2 - Moved the GSS-API based Negotiate authentication code.
2016-03-26 17:21:22 +00:00
Steve Holme
ad5e9bfd5d
vauth: Moved the Negotiate authentication code to the new vauth directory
...
Part 1 of 2 - Moved the SSPI based Negotiate authentication code.
2016-03-26 17:21:22 +00:00
Steve Holme
65f972b2e8
warnless.h: Removed spurious character from commit 696bc6b9c9
...
Not picked up by checksrc or Visual Studio but my own code review, this
would haven broken Intel based Unix builds - Perhaps I should learn to
type on my laptop's keyboard before committing!
2016-03-26 11:35:07 +00:00
Steve Holme
107cb78487
schannel: Fixed compilation warning from commit f8d88a4913
...
warning C4244: '=': conversion from 'int' to 'unsigned short', possible
loss of data
2016-03-26 11:14:07 +00:00
Steve Holme
696bc6b9c9
warnless?: Added some integer based conversion functions
2016-03-26 11:09:01 +00:00
Steve Holme
e04f5c576d
build: Corrected typos from commit 70e56939aa
2016-03-25 18:23:07 +00:00
Steve Holme
58a7bc96ec
vauth: Refactored function names after move to new vauth directory
...
Renamed all the SASL functions that moved to the new vauth directory to
include the correct module name.
2016-03-25 17:40:12 +00:00
Steve Holme
7d2a5a05f6
vauth: Updated the copyright year after recent changes
...
As most of this work was performed in 2015 but not pushed until 2016
updated the copyright year to reflect the public facing changes.
2016-03-25 17:40:12 +00:00
Steve Holme
70e56939aa
vauth: Moved the OAuth 2.0 authentication code to the new vauth directory
2016-03-25 15:11:10 +00:00
Steve Holme
6012fa5aee
vauth: Moved the NTLM authentication code to the new vauth directory
2016-03-25 15:11:09 +00:00
Steve Holme
e1dca8a117
vauth: Moved the Kerberos V5 authentication code to the new vauth directory
2016-03-25 15:11:07 +00:00
Steve Holme
568d26e0f5
digest.c: Fixed checksrc warnings
2016-03-25 12:17:34 +00:00
Steve Holme
51358a3f40
vauth: Moved the DIGEST authentication code to the new vauth directory
2016-03-25 12:05:23 +00:00
Steve Holme
ec5b8dc647
vauth: Moved the CRAM-MD5 authentication code to the new vauth directory
2016-03-25 12:05:23 +00:00
Steve Holme
6101e35819
vauth: Moved the ClearText authentication code to the new vauth directory
2016-03-25 12:05:23 +00:00
Steve Holme
685fee3828
vauth: Moved Curl_sasl_build_spn() to create the initial vauth source files
2016-03-25 09:12:01 +00:00
Steve Holme
dc72f8df0c
build: Updated all makefiles and project files for the new vauth directory
...
Updated the makefiles and Visual Studio project files to support moving
the authentication code to the new lib/vauth directory that was started
in commit 0d04e859e1 .
2016-03-25 09:11:59 +00:00
JDepooter
f8d88a4913
schannel: Add ALPN support
...
Add ALPN support for schannel. This allows cURL to negotiate
HTTP/2.0 connections when built with schannel.
Closes #724
2016-03-24 09:56:12 +01:00
Steve Holme
96fff9f6b5
http: Minor update based on CODE_STYLE guidelines
2016-03-24 06:35:23 +00:00
Daniel Stenberg
726ae07b07
multi: fix "Operation timed out after" timer
...
Use the local, reasonably updated, 'now' value when creating the message
string to output for the timeout condition.
Fixes #619
2016-03-23 23:03:08 +01:00
Daniel Stenberg
23ab481644
openssl: boringssl provides the same numbering as openssl
...
... so we don't need extra boringssl precautions for for
HAVE_ERR_REMOVE_THREAD_STATE_NOARG.
Pointed-out-by: David Benjamin
2016-03-23 14:59:41 +01:00
Daniel Stenberg
240cd84b49
openssl: fix ERR_remove_thread_state() for boringssl/libressl
...
The removed arg is only done in OpenSSL
Bug: https://twitter.com/xtraemeat/status/712564874098917376
2016-03-23 10:05:29 +01:00
Steve Holme
f974ffdd4b
hostip6: Fixed compilation warnings when verbose strings disabled
...
warning C4189: 'data': local variable is initialized but not referenced
...and some minor formatting/spacing changes.
2016-03-22 06:16:06 +00:00
Steve Holme
9351383745
connect/ntlm/http: Fixed compilation warnings when verbose strings disabled
...
warning C4189: 'data': local variable is initialized but not referenced
2016-03-20 17:51:06 +00:00
Steve Holme
89f397d7eb
openssl: Fixed compilation warning when /Wall enabled
...
warning C4706: assignment within conditional expression
2016-03-20 17:35:31 +00:00
Steve Holme
f046ac48d6
inet_pton.c: Fixed compilation warnings
...
warning: conversion to 'unsigned char' from 'int' may alter its value
2016-03-20 11:14:58 +00:00
Daniel Stenberg
80851028ef
mbedtls: fix compiler warning
...
vtls/mbedtls.h:67:36: warning: implicit declaration of function
‘mbedtls_sha256’ [-Wimplicit-function-declaration]
2016-03-19 22:37:21 +01:00
Steve Holme
4ff5cfd5fa
easy: Minor coding standard and style updates
...
Following commit c5744340db . Additionally removes the need for a second
'result code' variable as well.
2016-03-19 20:37:12 +00:00
Jay Satiro
c5744340db
easy: Remove poll failure check in easy_transfer
...
.. because curl_multi_wait can no longer signal poll failure.
follow-up to 77e1726
Bug: https://github.com/curl/curl/issues/707
2016-03-19 15:29:52 -04:00
Steve Holme
c142e73142
ftp/imap/pop3/smtp: Fixed compilation warning when /Wall enabled
...
warning C4706: assignment within conditional expression
2016-03-19 17:15:53 +00:00
Steve Holme
4ff2fbd1d5
config-w32.h: Fixed compilation warning when /Wall enabled
...
warning C4668: 'USE_IPV6' is not defined as a preprocessor macro,
replacing with '0' for '#if/#elif'
2016-03-19 11:05:06 +00:00