2 commits

Author	SHA1	Message	Date
Viktor Szakats	3058ed3df8	lib: use lib source directory as base include path ... Backtrack on previous change that aimed to solve the wrong `share.h` being included. It turns out it did not fix this issue. At the same time it introduced relative header filenames and the need to include the same headers differently depending on the source files' location, reducing readability and editability. Replace this method by re-adding curl's lib source directory to the header path and addressing headers by the their full, relative name to that base directory. Aligning with this method already used in src and tests. With these advantages: - makes includes easier to read, recognize, grep, sort, write, and copy between sources, - syncs the way these headers are included across curl components, - avoids the ambiguity between system `schannel.h`, `rustls.h` vs. local headers using the same names in `lib/vtls`, - silences clang-tidy `readability-duplicate-include` checker, which detects the above issue, Ref: https://clang.llvm.org/extra/clang-tidy/checks/readability/duplicate-include.html - possibly silences TIOBE coding standard warnings: `6.10.2.a: Don't use relative paths in #include statements.` - long shot: it works well with concatenated test sources, for clang-tidy-friendly custom unity builds. Ref: #20667 Slight downside: it's not enforced. If there happens to be a collision between a local `lib/*.h` header and a system one, the solution is to rename (possibly with its `.c` counterpart) into the `curl_` namespace. This is also the method used by curl in the past. Also: - curlx/inet_pton: reduce scope of an include. - toolx/tool_time: apply this to an include, and update VS project files accordingly. Also dropping unnecessary lib/curlx header path. - clang-tidy: enable `readability-duplicate-include`. Follow-up to 3887069c66 #19676 Follow-up to 625f2c1644 #16991 #16949 Closes #20623	2026-02-23 16:00:42 +01:00
Viktor Szakats	32454b954a	localtime: detect thread-safe alternatives and use them ... - add local API `toolx_localtime()` to wrap the banned function `localtime()`. Used from libcurl, libtests and test servers. - auto-detect and use `localtime_r()` where available (e.g. Linux). Also to support multi-threading. - use `localtime_s()` on Windows. It requires MSVC or mingw-w64 v4+. Also to support multi-threading. Use local workaround to also support mingw-w64 v3. - add `src/toolx` to keep internal APIs used by the curl tool and tests, but not by libcurl. `toolx_localtime()` is the first API in it. - replace `localtime()` calls with `toolx_localtime()`. Except in examples. - note Windows XP's default `msvcrt.dll` doesn't offer secure CRT APIs. XP likely needs a newer version of this DLL, or may not run. - note that `localtime()` mirrors `gmtime()`, with the difference that `gmtime()`'s internal wrapper lives in curlx. Also: - drop redundant `int` casts. Refs: https://learn.microsoft.com/cpp/c-runtime-library/reference/localtime-localtime32-localtime64 https://learn.microsoft.com/cpp/c-runtime-library/reference/localtime-s-localtime32-s-localtime64-s https://pubs.opengroup.org/onlinepubs/9799919799/functions/localtime.html https://linux.die.net/man/3/localtime_r Ref: #19955 (for `gmtime_r()`) Follow-up to 54d9f060b4 Closes #19957	2025-12-16 14:30:06 +01:00