mirror of
https://github.com/curl/curl.git
synced 2026-08-13 12:40:54 +03:00
- curl_multi_timeout() could return a timeout value of 0 even though nothing
was actually ready to get done, as the internal time resolution is higher than the returned millisecond timer. Therefore it could cause applications running on fast processors to do short bursts of busy-loops. curl_multi_timeout() will now only return 0 if the timeout is actually alreay triggered.
This commit is contained in:
parent
460459e8db
commit
ffd08df863
3 changed files with 21 additions and 1 deletions
13
lib/multi.c
13
lib/multi.c
|
|
@ -1541,6 +1541,7 @@ CURLMcode curl_multi_perform(CURLM *multi_handle, int *running_handles)
|
|||
|
||||
if( CURLM_OK >= returncode )
|
||||
update_timer(multi);
|
||||
|
||||
return returncode;
|
||||
}
|
||||
|
||||
|
|
@ -1951,9 +1952,19 @@ static CURLMcode multi_timeout(struct Curl_multi *multi,
|
|||
/* splay the lowest to the bottom */
|
||||
multi->timetree = Curl_splay(tv_zero, multi->timetree);
|
||||
|
||||
if(Curl_splaycomparekeys(multi->timetree->key, now) > 0)
|
||||
if(Curl_splaycomparekeys(multi->timetree->key, now) > 0) {
|
||||
/* some time left before expiration */
|
||||
*timeout_ms = curlx_tvdiff(multi->timetree->key, now);
|
||||
if(!*timeout_ms)
|
||||
/*
|
||||
* Since we only provide millisecond resolution on the returned value
|
||||
* and the diff might be less than one millisecond here, we don't
|
||||
* return zero as that may cause short bursts of busyloops on fast
|
||||
* processors while the diff is still present but less than one
|
||||
* millisecond! instead we return 1 until the time is ripe.
|
||||
*/
|
||||
*timeout_ms=1;
|
||||
}
|
||||
else
|
||||
/* 0 means immediately */
|
||||
*timeout_ms = 0;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue