romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-07-26 21:37:16 +03:00
Code Issues Projects Releases Packages Wiki Activity

url: Fixed memory leak in setstropt_userpwd()

Browse source 
setstropt_userpwd() was calling setstropt() in commit fddb7b44a7 to
set each of the login details which would duplicate the strings and
subsequently cause a memory leak.
This commit is contained in:
Steve Holme 2013-04-20 18:40:13 +01:00
parent 5821d5f111
commit fe880475ed
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
lib/url.c
View file

@ -333,15 +333,18 @@ static CURLcode setstropt_userpwd(char *option, char **user_storage,
if(!result) {
/* store username part of option */
if(user_storage)
setstropt(user_storage, userp);
Curl_safefree(*user_storage);
*user_storage = userp;
/* store password part of option */
if(pwd_storage)
setstropt(pwd_storage, passwdp);
Curl_safefree(*pwd_storage);
*pwd_storage = passwdp;
/* store options part of option */
if(options_storage)
setstropt(options_storage, optionsp);
Curl_safefree(*options_storage);
*options_storage = optionsp;
}
return result;