mirror of
https://github.com/curl/curl.git
synced 2026-04-15 00:41:41 +03:00
http: in alt-svc negotiation only allow supported HTTP versions
Without this patch, the handling of the alt-svc header added via
279a4772ae in curl-8.13.0 attempts to
connect to alternative services via different HTTP versions, even if the
target HTTP version is not supported by curl (i.e., not enabled at
compile-time). If I understand the code and RFC 7838 correctly, then we
should only attempt to migrate to supported protocols. Therefore,
`allowed_apns` should only contain such protocols, and we need to guard
its modification with `ifdefs` for supported HTTP versions.
This was discovered in a downstream bug report in Alpine Linux [1] where
it was reported that a Matrix client (using libcurl) was defunct after
the upgrade to curl-8.13.0. Further debugging revealed that this was due
to the Matrix server sending a `alt-svc: h3=":443";` HTTP header,
causing curl to attempt migration to HTTP3 even though Alpine's curl
version is compiled without HTTP3 support.
I am not sure if this is the best place in the code to address this
or if the `allowed` bitmask shouldn't contain unsupported versions
in the first place. However, since there are existing `ifdefs` in
this function for source (not destination) ALP selection, it may
be a good fit to address this here.
[1]: https://gitlab.alpinelinux.org/alpine/aports/-/issues/17062
Closes #17037
This commit is contained in:
parent
a0ebac0130
commit
fbdb1e1dbe
1 changed files with 4 additions and 0 deletions
|
|
@ -3049,10 +3049,14 @@ static CURLcode parse_connect_to_slist(struct Curl_easy *data,
|
|||
|
||||
DEBUGF(infof(data, "Alt-svc check wanted=%x, allowed=%x",
|
||||
neg->wanted, neg->allowed));
|
||||
#ifdef USE_HTTP3
|
||||
if(neg->allowed & CURL_HTTP_V3x)
|
||||
allowed_alpns |= ALPN_h3;
|
||||
#endif
|
||||
#ifdef USE_HTTP2
|
||||
if(neg->allowed & CURL_HTTP_V2x)
|
||||
allowed_alpns |= ALPN_h2;
|
||||
#endif
|
||||
if(neg->allowed & CURL_HTTP_V1x)
|
||||
allowed_alpns |= ALPN_h1;
|
||||
allowed_alpns &= (int)data->asi->flags;
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue