romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-05-14 02:26:21 +03:00
Code Issues Projects Releases Packages Wiki Activity

conncache: prevent integer overflow in maxconnects calculation

Browse source 
Closes #19271
This commit is contained in:
x2018 2025-10-28 23:35:45 +08:00 • committed by Daniel Stenberg
parent c1f1b66d78
commit fbc4d59151
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

11
lib/conncache.c
View file

@ -531,12 +531,19 @@ static bool cpool_foreach(struct Curl_easy *data,
bool Curl_cpool_conn_now_idle(struct Curl_easy *data,
struct connectdata *conn)
{
unsigned int maxconnects = !data->multi->maxconnects ?
(Curl_multi_xfers_running(data->multi) * 4) : data->multi->maxconnects;
unsigned int maxconnects;
struct connectdata *oldest_idle = NULL;
struct cpool *cpool = cpool_get_instance(data);
bool kept = TRUE;
if(!data->multi->maxconnects) {
unsigned int running = Curl_multi_xfers_running(data->multi);
maxconnects = (running <= UINT_MAX / 4) ? running * 4 : UINT_MAX;
}
else {
maxconnects = data->multi->maxconnects;
}
conn->lastused = curlx_now(); /* it was used up until now */
if(cpool && maxconnects) {
/* may be called form a callback already under lock */