romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-08-24 16:23:34 +03:00
Code Issues Projects Releases Packages Wiki Activity

curl: exit the create_transfers loop on errors

Browse source 
When looping around the ranges and given URLs to create transfers, all
errors should exit the loop and return. Previously it would keep
looping.

Reported-by: SumatraPeter on github
Bug: #4393
Closes #4396
This commit is contained in:
Daniel Stenberg 2019-09-21 23:46:41 +02:00
parent 5ee88eee68
commit f8a2058533
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/tool_operate.c
View file

@ -1885,15 +1885,9 @@ static CURLcode create_transfers(struct GlobalConfig *global,
urls = NULL; urls = NULL;
} }
if(infilenum > 1) { if(result)
/* when file globbing, exit loop upon critical error */ /* exit loop upon error */
if(is_fatal_error(result))
break;
}
else if(result)
/* when not file globbing, exit loop upon any error */
break; break;
} /* loop to the next globbed upload file */ } /* loop to the next globbed upload file */
/* Free loop-local allocated memory */ /* Free loop-local allocated memory */
@ -1913,6 +1907,9 @@ static CURLcode create_transfers(struct GlobalConfig *global,
Curl_safefree(urlnode->infile); Curl_safefree(urlnode->infile);
urlnode->flags = 0; urlnode->flags = 0;
if(result)
/* exit loop upon error */
break;
} /* for-loop through all URLs */ } /* for-loop through all URLs */
quit_curl: quit_curl: