romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-05-16 17:36:20 +03:00
Code Issues Projects Releases Packages Wiki Activity

cfilters: make Curl_conn_connect always assign 'done'

Browse source 
It could return error without assigning it, and we have a caller in
multi.c that assumes it gets set.

Spotted by CodeSonar
Closes #13884
This commit is contained in:
Daniel Stenberg 2024-06-05 08:31:11 +02:00
parent 1313da9a1d
commit f75aa2857f
No known key found for this signature in database
GPG key ID: 5CC908FDB71E12C2
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
lib/cfilters.c
View file

@ -345,8 +345,10 @@ CURLcode Curl_conn_connect(struct Curl_easy *data,
cf = data->conn->cfilter[sockindex];
DEBUGASSERT(cf);
if(!cf)
if(!cf) {
*done = FALSE;
return CURLE_FAILED_INIT;
}
*done = cf->connected;
if(!*done) {