romenskiy2012/curl
1
0
Fork 0
mirror of https://github.com/curl/curl.git synced 2026-08-25 07:23:31 +03:00
Code Issues Projects Releases Packages Wiki Activity

cmake: fix CURL_WERROR=ON for old CMake and use it in GHA/linux-old

Browse source 
- cmake: fix `-pedantic-errors` for old CMake with `CURL_WERROR=ON` set.

  `-pedantic-errors` option throws a warning with GCC (all versions) and
  makes `check_symbol_exists()` fail in CMake versions older than
  v3.23.0 (2022-03-29), when CMake introduced a workaround:

  https://gitlab.kitware.com/cmake/cmake/-/issues/13208
  eeb4540116
  1ab7c3cd28

  Follow-up to 3829759bd0 #12489

- set `CURL_WERROR=ON` for the `linux-old` job in CI.

Closes #13282
This commit is contained in:
Viktor Szakats 2024-04-04 10:45:01 +00:00
parent 20c1b2d75e
commit f43545e91b
No known key found for this signature in database
GPG key ID: B5ABD165E2AEF201
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
CMake/PickyWarnings.cmake
View file

@ -25,7 +25,10 @@ include(CheckCCompilerFlag)
unset(WPICKY)
if(CURL_WERROR AND CMAKE_COMPILER_IS_GNUCC AND NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 5.0)
if(CURL_WERROR AND
CMAKE_COMPILER_IS_GNUCC AND
NOT CMAKE_C_COMPILER_VERSION VERSION_LESS 5.0 AND
NOT CMAKE_VERSION VERSION_LESS 3.23.0) # check_symbol_exists() incompatible with GCC -pedantic-errors in earlier CMake versions
set(WPICKY "${WPICKY} -pedantic-errors")
endif()