From ee0dc8353d31787231e3a31154877df011524086 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Mon, 8 Jun 2026 01:26:59 +0200 Subject: [PATCH] avoid another warning ``` /Users/runner/work/curl/curl/lib/socketpair.c:329:15: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if((err == SOCKEWOULDBLOCK) ~~~~^~~~~~~~~~~~~~~~~~ /Users/runner/work/curl/curl/lib/socketpair.c:329:15: note: remove extraneous parentheses around the comparison to silence this warning if((err == SOCKEWOULDBLOCK) ~ ^ ~ /Users/runner/work/curl/curl/lib/socketpair.c:329:15: note: use '=' to turn this equality comparison into an assignment if((err == SOCKEWOULDBLOCK) ^~ = /Users/runner/work/curl/curl/lib/socketpair.c:359:21: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if((SOCKERRNO == SOCKEWOULDBLOCK) ~~~~~~~~~~^~~~~~~~~~~~~~~~~~ /Users/runner/work/curl/curl/lib/socketpair.c:359:21: note: remove extraneous parentheses around the comparison to silence this warning if((SOCKERRNO == SOCKEWOULDBLOCK) ~ ^ ~ /Users/runner/work/curl/curl/lib/socketpair.c:359:21: note: use '=' to turn this equality comparison into an assignment if((SOCKERRNO == SOCKEWOULDBLOCK) ^~ = 2 errors generated. ``` https://github.com/curl/curl/actions/runs/27107980068/job/80000462156?pr=21893 --- lib/socketpair.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/socketpair.c b/lib/socketpair.c index 228aaa879d..1fade3782a 100644 --- a/lib/socketpair.c +++ b/lib/socketpair.c @@ -326,9 +326,9 @@ int Curl_wakeup_signal(curl_socket_t socks[2]) #else if(SOCKEINTR == err) continue; - if((err == SOCKEWOULDBLOCK) + if(err == SOCKEWOULDBLOCK #if EAGAIN != SOCKEWOULDBLOCK - || (err == EAGAIN) + || err == EAGAIN #endif ) err = 0; /* wakeup is already ongoing */ @@ -356,9 +356,9 @@ CURLcode Curl_wakeup_consume(curl_socket_t socks[2], bool all) #else if(SOCKEINTR == SOCKERRNO) continue; - if((SOCKERRNO == SOCKEWOULDBLOCK) + if(SOCKERRNO == SOCKEWOULDBLOCK #if EAGAIN != SOCKEWOULDBLOCK - || (SOCKERRNO == EAGAIN) + || SOCKERRNO == EAGAIN #endif ) break;