From e9112f7076b754eb4234133441266a03fb7c2993 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Mon, 9 Mar 2026 00:20:54 +0100 Subject: [PATCH] make the warning an err --- CMake/PickyWarnings.cmake | 4 ---- m4/curl-compilers.m4 | 4 ---- 2 files changed, 8 deletions(-) diff --git a/CMake/PickyWarnings.cmake b/CMake/PickyWarnings.cmake index c811d2ef47..6d445159f4 100644 --- a/CMake/PickyWarnings.cmake +++ b/CMake/PickyWarnings.cmake @@ -251,8 +251,6 @@ if(PICKY_COMPILER) (CMAKE_C_COMPILER_ID STREQUAL "AppleClang" AND CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL 17.0)) list(APPEND _picky_enable -Wformat-signedness # clang 19.1 gcc 5.1 appleclang 17.0 # In clang-cl enums are signed ints by default - -Wno-error=format-signedness - -Wno-error=format ) endif() if((CMAKE_C_COMPILER_ID STREQUAL "Clang" AND CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL 21.1) OR @@ -309,8 +307,6 @@ if(PICKY_COMPILER) list(APPEND _picky_enable -Warray-bounds=2 # clang 2.9 gcc 5.0 (clang default: -Warray-bounds) -Wformat-signedness # clang 19.1 gcc 5.1 appleclang 17.0 - -Wno-error=format-signedness - -Wno-error=format ) endif() if(CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL 6.0) diff --git a/m4/curl-compilers.m4 b/m4/curl-compilers.m4 index fe72cb81a5..5607952878 100644 --- a/m4/curl-compilers.m4 +++ b/m4/curl-compilers.m4 @@ -941,8 +941,6 @@ AC_DEFUN([CURL_SET_COMPILER_WARNING_OPTS], [ dnl clang 19 or later if test "$compiler_num" -ge "1901"; then CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [format-signedness]) - tmp_CFLAGS="$tmp_CFLAGS -Wno-error=format-signedness" - tmp_CFLAGS="$tmp_CFLAGS -Wno-error=format" fi dnl clang 20 or later if test "$compiler_num" -ge "2001"; then @@ -1137,8 +1135,6 @@ AC_DEFUN([CURL_SET_COMPILER_WARNING_OPTS], [ if test "$compiler_num" -ge "500"; then tmp_CFLAGS="$tmp_CFLAGS -Warray-bounds=2" CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [format-signedness]) - tmp_CFLAGS="$tmp_CFLAGS -Wno-error=format-signedness" - tmp_CFLAGS="$tmp_CFLAGS -Wno-error=format" fi dnl Only gcc 6 or later