From e8c64a06c5031bd59fdf914e8ac6c8524c0e4375 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Sun, 22 Mar 2026 12:55:42 +0100 Subject: [PATCH] asyn-thrdd: fix clang-tidy unused value warning with `-DCURL_DISABLE_SOCKETPAIR=ON`. ``` lib/asyn-thrdd.c:227:5: error: Value stored to 'do_abort' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors] 227 | do_abort = addr_ctx->do_abort; | ^ ~~~~~~~~~~~~~~~~~~ ``` Closes #21061 --- lib/asyn-thrdd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/asyn-thrdd.c b/lib/asyn-thrdd.c index 22418f5291..52278b24fa 100644 --- a/lib/asyn-thrdd.c +++ b/lib/asyn-thrdd.c @@ -223,10 +223,11 @@ static CURL_THREAD_RETURN_T CURL_STDCALL getaddrinfo_thread(void *arg) Curl_addrinfo_set_port(addr_ctx->res, addr_ctx->port); } +#ifndef CURL_DISABLE_SOCKETPAIR Curl_mutex_acquire(&addr_ctx->mutx); do_abort = addr_ctx->do_abort; Curl_mutex_release(&addr_ctx->mutx); -#ifndef CURL_DISABLE_SOCKETPAIR + if(!do_abort) { /* Thread is done, notify transfer */ int err = Curl_wakeup_signal(addr_ctx->sock_pair);