clang-tidy: enable more checks, fix fallouts

- enable three checks:
  - bugprone-invalid-enum-default-initialization
  - bugprone-sizeof-expression
  - readability-inconsistent-declaration-parameter-name (strict)
- fix remaining discrepancies with arg names in prototypes
  and implementation, in strict mode.
- document reason for some checks tested but not enabled.

Closes #20794
This commit is contained in:
Viktor Szakats 2026-03-03 01:58:29 +01:00
parent e0dd6eb4a4
commit df6014894b
No known key found for this signature in database
34 changed files with 222 additions and 209 deletions

View file

@ -294,7 +294,7 @@ ParameterError str2unummax(long *val, const char *str, long max)
* data.
*/
ParameterError secs2ms(long *valp, const char *str)
ParameterError secs2ms(long *val, const char *str)
{
curl_off_t secs;
long ms = 0;
@ -326,7 +326,7 @@ ParameterError secs2ms(long *valp, const char *str)
ms = ((long)fracs * 100) / digs[len - 1];
}
*valp = ((long)secs * 1000) + ms;
*val = ((long)secs * 1000) + ms;
return PARAM_OK;
}